-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add cdp, incentive, committee migrations for v0.9 -> v0.11 #633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karzak
requested review from
nddeluca,
rhuairahrighairidh,
denalimarsh and
fedekunze
August 21, 2020 21:42
karzak
changed the title
[R4R] Add cdp, incentive migrations for v0.9 -> v0.11
[R4R] Add cdp, incentive, committee migrations for v0.9 -> v0.11
Aug 23, 2020
Initial thoughts:
|
karzak
changed the title
[R4R] Add cdp, incentive, committee migrations for v0.9 -> v0.11
[WIP] Add cdp, incentive, committee migrations for v0.9 -> v0.11
Sep 1, 2020
karzak
added
WIP
PR is a work in progress and not ready for review
and removed
R4R
When a PR is ready for review
labels
Sep 1, 2020
Closing in favor of smaller, individual PRs (662-667+) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates exported state from v0.9 (kava-3) to v0.11 (kava-4) for cdp, incentive and committee to account for changes introduced in #629. Includes tests and test data from kava-3.
Removes code related to kava-2 -> kava-3 migration, as it implicitly assumed that the current state of
app
would not have breaking changes. Since this is no longer true, and we don't need to support kava-2 -> kava-3 migrations in the client for any reason I can think of, I removed thatkava-3
section ofcontrib
.For reviewers:
Does this structure make sense (legacy v0.9, v0.11 types in the package, migrations at the top level)?
Any additional tests needed for these modules?
TODO:
[ ] Include tests that verify migrations against current master branch, in additional to the legacy
v011
. Ideally, tests against master should have a way of being ignored once v0.11 is released and we've made breaking changes.[ ] Include CDP genesis state changes from #644
[ ] Include incentive state changes from #655
[ ] Include auth.Accounts state changes from #625