Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add cdp, incentive, committee migrations for v0.9 -> v0.11 #633

Closed
wants to merge 27 commits into from

Conversation

karzak
Copy link
Member

@karzak karzak commented Aug 21, 2020

Migrates exported state from v0.9 (kava-3) to v0.11 (kava-4) for cdp, incentive and committee to account for changes introduced in #629. Includes tests and test data from kava-3.

Removes code related to kava-2 -> kava-3 migration, as it implicitly assumed that the current state of app would not have breaking changes. Since this is no longer true, and we don't need to support kava-2 -> kava-3 migrations in the client for any reason I can think of, I removed that kava-3 section of contrib.

For reviewers:
Does this structure make sense (legacy v0.9, v0.11 types in the package, migrations at the top level)?
Any additional tests needed for these modules?

TODO:
[ ] Include tests that verify migrations against current master branch, in additional to the legacy v011. Ideally, tests against master should have a way of being ignored once v0.11 is released and we've made breaking changes.
[ ] Include CDP genesis state changes from #644
[ ] Include incentive state changes from #655
[ ] Include auth.Accounts state changes from #625

@karzak karzak added R4R When a PR is ready for review v0.10+ labels Aug 21, 2020
@karzak karzak changed the title [R4R] Add cdp, incentive migrations for v0.9 -> v0.11 [R4R] Add cdp, incentive, committee migrations for v0.9 -> v0.11 Aug 23, 2020
@rhuairahrighairidh
Copy link
Member

Initial thoughts:

  • I would vote to use the types from the module types folders rather than the copied types in legacy/v0_11 folders. In cosmos, they merged a few PRs that changed their types slightly, but the changes weren't copied over to the legacy folders, so the migrations siliently broke.
  • I like the current tests that migrate a lot of data, then check it passes validation. Might be worth also having tests that migrate a small genesis state and check it's equal to hand migrated json. I remember making a lot of small mistakes on the previous migration that weren't caught by genesis validation.

@karzak karzak marked this pull request as draft September 1, 2020 15:39
@karzak karzak changed the title [R4R] Add cdp, incentive, committee migrations for v0.9 -> v0.11 [WIP] Add cdp, incentive, committee migrations for v0.9 -> v0.11 Sep 1, 2020
@karzak karzak added WIP PR is a work in progress and not ready for review and removed R4R When a PR is ready for review labels Sep 1, 2020
@karzak
Copy link
Member Author

karzak commented Sep 25, 2020

Closing in favor of smaller, individual PRs (662-667+)

@karzak karzak closed this Sep 25, 2020
@karzak karzak deleted the kd-add-cdp-migrations branch November 5, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP PR is a work in progress and not ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants