Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching proofs resets selection #3347

Closed
FliegendeWurst opened this issue Nov 12, 2023 · 1 comment · Fixed by #3349
Closed

Switching proofs resets selection #3347

FliegendeWurst opened this issue Nov 12, 2023 · 1 comment · Fixed by #3349
Assignees
Milestone

Comments

@FliegendeWurst
Copy link
Member

Description

When switching proofs, the selected node is not restored correctly.

Reproducible

always

Steps to reproduce

  1. Load two proofs
  2. Select a node X in proof A
  3. Switch to proof B
  4. Switch to proof A

Expectation: I see node X
Actual result: I see some other node

Additional information

Probably a regression from #3341


@unp1
Copy link
Member

unp1 commented Nov 13, 2023

Sorry, my bad. It worked at some time during the previous PR, but seems to have been broken when submitted. PR#3349 fixes that issue (and reduces unnecessary selected proof changed events further)

@unp1 unp1 self-assigned this Nov 13, 2023
unp1 added a commit that referenced this issue Nov 20, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 21, 2023
wadoon added a commit that referenced this issue Dec 7, 2023
* origin/weigl/jsonrpc: (71 commits)
  Bump com.diffplug.spotless from 6.22.0 to 6.23.0
  Bump ch.qos.logback:logback-classic from 1.4.11 to 1.4.12
  prepare config using dedicated labels
  Add a configuration for automatic generation of changelogs by Github
  Prevent second reading of declarations in KeYUserProblemFile
  Re-enable check for non-unique taclet names and remove two taclet duplicates
  Bump org.junit.vintage:junit-vintage-engine from 5.10.0 to 5.10.1
  Improve selection consistency in task tree view
  Undo unrelated change that got checked in.
  Use selection in task tree view to change chosen problem not mouse events
  Slight alternative in who selects the first node after loading (should be safer)
  Remove further unnecessary proof change events
  Fix (for issue #3347) that node selection gets forgotten when switching between proofs
  Merge errors
  spotless and merge errors
  add throwable adapter
  running for primitive data types, somethings wrong in de-/serialization
  more doc and py generation
  working on a working minimal version
  Creating an JSON-RPC API
  ...
wadoon added a commit that referenced this issue Dec 7, 2023
* origin/main: (58 commits)
  Bump com.diffplug.spotless from 6.23.0 to 6.23.3
  Bump ch.qos.logback:logback-classic from 1.4.12 to 1.4.14
  Bump com.diffplug.spotless from 6.22.0 to 6.23.0
  Bump ch.qos.logback:logback-classic from 1.4.11 to 1.4.12
  prepare config using dedicated labels
  Add a configuration for automatic generation of changelogs by Github
  Prevent second reading of declarations in KeYUserProblemFile
  Re-enable check for non-unique taclet names and remove two taclet duplicates
  Bump org.junit.vintage:junit-vintage-engine from 5.10.0 to 5.10.1
  Improve selection consistency in task tree view
  Undo unrelated change that got checked in.
  Use selection in task tree view to change chosen problem not mouse events
  Slight alternative in who selects the first node after loading (should be safer)
  Remove further unnecessary proof change events
  Fix (for issue #3347) that node selection gets forgotten when switching between proofs
  Merge errors
  CI: make codecov checks non-failing
  Update .github/pull_request_template.md
  Update .github/pull_request_template.md
  Update .github/pull_request_template.md
  ...

# Conflicts:
#	gradle/wrapper/gradle-wrapper.jar
#	gradlew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants