Fix (for issue #3347) that node selection gets forgotten when switching between proofs #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3349 +/- ##
============================================
- Coverage 37.94% 37.92% -0.02%
+ Complexity 17001 16994 -7
============================================
Files 2059 2059
Lines 125973 125973
Branches 21273 21273
============================================
- Hits 47797 47772 -25
- Misses 72293 72317 +24
- Partials 5883 5884 +1 ☔ View full report in Codecov by Sentry. |
FliegendeWurst
suggested changes
Nov 13, 2023
There was a problem hiding this comment.
Still broken, but now it only updates the sequent view to show a closed goal, and not the proof tree.
FWIW I fully expected these regressions when I originally made changes to the selection event handling in #3289. This area of KeY is extremely fragile.
|
Thanks. I hope the latest fix works now reliable. |
FliegendeWurst
approved these changes
Nov 13, 2023
…ng between proofs
Drodt
approved these changes
Nov 21, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.