-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Fix javacc deprecation warning #3016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed recenty: I like that, but would suggest we do the other item here too.
I wondered: Is it enough to add our own implementations. Would the generator not still produce its versions in the gen folder? Can we reliably guarantee that these versions have priority over the generated java files? Is this build in into gradle's build process?
key.core/src/main/javacc/de/uka/ilkd/key/parser/proofjava/JavaCharStream.java
Outdated
Show resolved
Hide resolved
key.core/src/main/javacc/de/uka/ilkd/key/parser/proofjava/JavaCharStream.java
Outdated
Show resolved
Hide resolved
I added draft because this does not work. The files get ignored and regenerated. This happens for the already existing Token.java as well, it serves no purpose right now as fas as i see it. |
Does the copy in Line 48 does not do the trick for |
Oh I didn't see that. However the log output states that
|
JavaCC generates these files, and we are overwriting them. The internal mechanism of JavaCC 4.0 to detect these files seems to be broken. |
Did everything you asked for, the warnings are gone as far as I see it and I added the exception so Should be ready to be merged once the tests are done. |
Fixes the warning