Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin regex version in dev-dependencies #315

Closed

Conversation

giraffate
Copy link
Contributor

Fix #314

The regex v1.8.x needs the rustc 1.60.0 or newer, so we pins its version.

@giraffate giraffate mentioned this pull request Jun 8, 2023
@giraffate
Copy link
Contributor Author

Oh, Clippy in CI fails, I'll address it later.

@Keats
Copy link
Owner

Keats commented Jun 8, 2023

Maybe it's ok to do #303 now that it's been 6 months since 1.67 release

@giraffate
Copy link
Contributor Author

Okay, it looks good!

@giraffate giraffate closed this Jun 9, 2023
@giraffate giraffate deleted the pin_regex_in_dev_dependencies branch June 9, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The pinned tests fails
2 participants