Add no_std support #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When building with |
|
Can you add a no-std run to CI? The MSRV bump is fine |
|
Done. |
Keats
reviewed
May 7, 2020
| - name: Check formatting | ||
| if: matrix.rust == 'stable' | ||
| run: | | ||
| cargo fmt --all -- --check |
There was a problem hiding this comment.
Note to myself: I'll move it to another CI check, along with clippy probably
There was a problem hiding this comment.
ripgrep actually uses a separate job: https://github.com/BurntSushi/ripgrep/blob/a2e6aec7a4d9382941932245e8854f0ae5703a5e/.github/workflows/ci.yml#L185-L200
There was a problem hiding this comment.
Yep, I have something like that for the Rust repos at work: https://github.com/onecodex/needletail/blob/master/.github/workflows/tests.yml
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also replaced
randwith a smaller dependency,getrandom, because that's pretty much whatOsRng::fill_bytesis: https://github.com/rust-random/rand/blob/bf8b5a98ac95da19953f0b3b0f6da6ec8eda940b/rand_core/src/os.rs#L66-L69.OsRng::fill_bytes's return value was previously ignored, I assume that's not intended, so I changed that.