Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plgx prerequisites #99

Closed
dannoe opened this issue Apr 10, 2020 · 2 comments · Fixed by #125
Closed

Update plgx prerequisites #99

dannoe opened this issue Apr 10, 2020 · 2 comments · Fixed by #125

Comments

@dannoe
Copy link
Contributor

dannoe commented Apr 10, 2020

<DotNetVersion>3.5</DotNetVersion>

We have to increment this to 4.5. We use several things that are not included in the .NET Framework
3.5. Used for displaying a nicer error message to the user, if the required .net framework is not installed at plgx compilation time.
see Plugin Development (2.x) - KeePass

@dannoe dannoe added this to To do in Kanban board via automation Apr 10, 2020
@Sanaki
Copy link

Sanaki commented Apr 10, 2020

This may break mono builds. While I don't know the reason, mono seems to internally report an old version of .net despite being much more up to date.
Another project's fix when encountering this issue: dlech/KeeAgent@c09f3dd

EDIT:

For compatibility reasons, Mono’s System.Environment.Version property returns the version of the .NET profile that Mono targets, not the version of Mono that is being used. This should be the same version number that .NET would return. As such, it will return 2.0.X.Y when running under the 2.0 profile, even though it’s running under Mono 1.1. :-)
Source

So yeah, I'm not sure what's going on there. Seems like that shouldn't be an issue.

@robinvanpoppel
Copy link
Collaborator

That 3.5 feels wrong indeed. This is an area that I have not really explored myself. Would it be possible to bump to 4 at least? And maybe we can add specific github actions that build and test the plugin against mono to ensure compatiblity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Kanban board
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants