Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed a .NET Framework 4.5 type to fully support .NET Framework 4.0 #125

Merged
merged 1 commit into from Apr 18, 2020
Merged

Removed a .NET Framework 4.5 type to fully support .NET Framework 4.0 #125

merged 1 commit into from Apr 18, 2020

Conversation

dannoe
Copy link
Contributor

@dannoe dannoe commented Apr 18, 2020 •
edited

  • Removed the IReadOnlyList type.
  • Bumped the required plgx DotNetVersion to 4.0.

This fixes #99 and maybe #124

@dannoe dannoe changed the title Removed a .NET 4.5 type to fully support .NET 4.0 Removed a .NET Framework 4.5 type to fully support .NET Framework 4.0 Apr 18, 2020
@dannoe dannoe mentioned this pull request Apr 18, 2020
Closed
robinvanpoppel
robinvanpoppel approved these changes Apr 18, 2020
View reviewed changes
Copy link
Collaborator

@robinvanpoppel robinvanpoppel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not expecting this at all. Good find.

Sorry for the close. The UX of the mobile github app could be a bit better.

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dannoe dannoe merged commit 65d3ea7 into master Apr 18, 2020
@dannoe dannoe deleted the fix-99-and-maybe-124 branch April 18, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinvanpoppel robinvanpoppel robinvanpoppel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update plgx prerequisites
2 participants
@dannoe @robinvanpoppel