Tweak base32 implementation #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tracked down original implementation of Base32.cs. * Applied their license * Applied our project formatting. * Fixed a violation of the RFC with empty strings - Tweak ExtIsBase32, so that trailing = (padding) is allowed
robinvanpoppel
changed the title
dannoe
requested changes
Apr 24, 2020
dannoe
reviewed
Apr 24, 2020
KeeTrayTOTP.Tests/Base32Tests.cs
Outdated
| var actual = InvalidSeed.IsBase32(out string invalidChars); | ||
|
|
||
| actual.Should().BeFalse(); | ||
| invalidChars.Should().Be("!======!"); |
There was a problem hiding this comment.
And this should then only return !! as invalidChars, shouldn't it?
There was a problem hiding this comment.
This would depend on the outcome above. I think it could say just '!', or '!!', but in this example the = is not used as padding and is invalid as well...
|
Kudos, SonarCloud Quality Gate passed!
|
dannoe
approved these changes
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When done, should close #130