Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak base32 implementation #131

Merged
merged 5 commits into from
Apr 25, 2020
Merged

Tweak base32 implementation #131

merged 5 commits into from
Apr 25, 2020

Commits on Apr 24, 2020

  1. - Added tests for the base32 implementation. 

    - Tracked down original implementation of Base32.cs.
  * Applied their license
  * Applied our project formatting.
  * Fixed a violation of the RFC with empty strings
- Tweak ExtIsBase32, so that trailing = (padding) is allowed
    @robinvanpoppel
    robinvanpoppel committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    4a023a4 View commit details
    Browse the repository at this point in the history

  2. Fix remaining unit tests and refactor

    @robinvanpoppel
    robinvanpoppel committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    167cd91 View commit details
    Browse the repository at this point in the history

  3. Trim padding characters when generating QR code

    @robinvanpoppel
    robinvanpoppel committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    67e2eec View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2020

  1. Merge branch 'master' into base32

    @robinvanpoppel
    robinvanpoppel committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    31931b4 View commit details
    Browse the repository at this point in the history

  2. Add special validation for padding

    @robinvanpoppel
    robinvanpoppel committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    7821b69 View commit details
    Browse the repository at this point in the history