Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Bad Request #37

Closed
wants to merge 1 commit into from
Closed

Removed Bad Request #37

wants to merge 1 commit into from

Conversation

realabbas
Copy link

Removed Favicon.ico Bad Request

I ran a test on this website and found it was making 2 requests with one bad request.

image

I made the necessary changes and now the overall page speed has increased and the total request counts to 1 with no bad request.

I also deployed the new project on netlify and compared it with the previous version of the website and found the following metrics. Have a look

image

Read full report on Gtmetrix : Bestmotherfucking.website Report

So overall the benefits of this pull request is

  • Bad request removed
  • Page Speed Increased
  • Page Size Decreased

@KeenRivals
Copy link
Owner

KeenRivals commented Oct 18, 2019 via email

@realabbas
Copy link
Author

realabbas commented Oct 18, 2019

Seems kind of hacky, but I've been a bit annoyed by the favicon requests for a while. I don't think it really affects browser loads since they seem to do it in the background asynchronously. That text looks like the start of a PNG header, but what happens if you give it an empty data url?

It does not make the browser interpret the current HTML code as favicon (which would be the case with href="#" or href=""

Also, removing the bad requests provides a lot of benefits as mentioned above

@KeenRivals
Copy link
Owner

I meant something like "data:image/png;base64,"

@realabbas
Copy link
Author

I meant something like "data:image/png;base64,"

Yeah, it will work fine.
I ran a test again and it's working

image

Report: https://gtmetrix.com/reports/dazzling-stonebraker-28ef9c.netlify.com/c8UeD2So

@realabbas
Copy link
Author

Hey @KeenRivals Review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants