Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/3 add virtualenv #12

Merged
merged 2 commits into from
Jul 23, 2018
Merged

Feature/3 add virtualenv #12

merged 2 commits into from
Jul 23, 2018

Conversation

Createdd
Copy link
Member

  • adding explanation for getting started with virtualenv
  • clean up and improve other getting started instructions
  • add pipfile as it is recommended to check it into version control

closes #3

@Createdd Createdd added the enhancement 🚀 New feature or request label Jul 23, 2018
@Createdd Createdd self-assigned this Jul 23, 2018
@Createdd Createdd requested a review from liadmagen July 23, 2018 16:21
liadmagen
liadmagen reviewed Jul 23, 2018
View reviewed changes
Copy link
Member

@liadmagen liadmagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about the pip and pip lock files? I think it should not be in the commit...

Pipfile.lock
@@ -0,0 +1,370 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this file should be checked in? I think it's supposed to be local for the user and in git ignore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say yes: pypa/pipenv#598

It is like package.json / yarn lockfile. it helps for installing the packages and ditches the (potentially dangerous "requirements.txt" use)

@liadmagen liadmagen merged commit 5a55180 into master Jul 23, 2018
@liadmagen liadmagen deleted the feature/3_add_virtualenv branch July 23, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liadmagen liadmagen liadmagen approved these changes

@accesslint AccessLint accesslint approved these changes

Assignees

@Createdd Createdd

Labels
enhancement 🚀 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add virtualenv to "getting started" section in readme
2 participants
@Createdd @liadmagen