-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad <init> method call from inside of a branch #12
Comments
Hopefully this resolves issue #12, in which execution fails due to the verifier complaining about an error in the PackageTree bytecode.
Wow. It's not clear to me whether this is a bug in the JDK or in Groovy, but either way I think I have a fix. I've published a snapshot build ( |
It's a bug in the 1.7 JDK. Please update your 1.7 JDK to at least version |
ok. I try to use com.getkeepsafe.dexcount:dexcount-gradle-plugin:0.2.1-SNAPSHOT
And I use the final version of JDK - 7u79 |
Here is the relevant JDK bug report http://bugs.java.com/view_bug.do?bug_id=8051012 Please try to update both your JDK and runtime to the latest versions and use the stable version. |
Apologies; the build is in Sonatype snapshots. Your buildscript {
repositories {
// other repositories e.g. jcenter() or mavenCentral()
maven { url 'https://oss.sonatype.org/content/repositories/snapshots' }
}
dependencies {
classpath 'com.getkeepsafe.dexcount:dexcount-gradle-plugin:0.2.1-SNAPSHOT'
}
} |
Hopefully this resolves issue #12, in which execution fails due to the verifier complaining about an error in the PackageTree bytecode.
I've released a stable version 0.2.1 that no longer hits this buggy behavior in the JDK. You really should upgrade, but even if you can't the new version should work for you. |
Happened again to me OTL |
Oh, that's annoying - sorry. What does 'OTL' mean? Also, would you please paste the output of |
OTL is http://orig05.deviantart.net/b450/f/2013/014/8/b/otl_by_gentlehorizon-d5rjuo4.jpg hehe Gradle 2.12Build time: 2016-03-14 08:32:03 UTC Groovy: 2.4.4 |
Bahaha, I'm getting old. How apropos for this kind of bug. Allegedly this was fixed, and the fix was applied to JVM 8u20, but clearly you're experiencing the bug, so... I have a speculative fix that I'll push momentarily. I can't repro this myself, so maybe it works, maybe it doesn't. I'm 99% sure though, that this regressed because I added a constructor to PackageTree and used arguments with default values. It's informative to look at the output from TL;DR: Try 0.5.1-SNAPSHOT tomorrow; make sure you've added the appropriate snapshot repo as described above in this issue. Let me know if it works. |
Fixes KeepSafe#12 This regressed when I added default-value parameters to PackageTree; this compiles to an unholy horror of pass-args-by-global-static dynamicism and other unspeakables, including the verifier crash. This commit removes default parameters, restoring order to PackageTree once again.
Thanks, I will try it at Monday :) Sorry I don't really know what you are talking about because I'm just a beginner in the Android development and all of these things are making me crazy. Not to mention, I'm not a fan of Java programming. I'm just trying to be persistent and hit my goal haha. |
Fixes #12 This regressed when I added default-value parameters to PackageTree; this compiles to an unholy horror of pass-args-by-global-static dynamicism and other unspeakables, including the verifier crash. This commit removes default parameters, restoring order to PackageTree once again.
Whoops, accidentally closed this automatically. Re-opening. Please do try it! I'd love to know that 0.5.1-SNAPSHOT does indeed fix the issue; it would be super helpful to hear how it works for you. Thanks! |
Thanks! It's solved. However, I must add mavenCentral to the the repositories. If I don't add it then This is the buildscript I use in the
|
Interesting; I assume you had |
Yes I have it in the This is my
|
My java version:
This causes the same error for me:
This works for me:
|
Thanks for your report. We have not yet released a non-snapshot build that has this bugfix; we just haven't had the bandwidth lately. It's on the radar! |
Gradle 2.4
Build time: 2015-05-05 08:09:24 UTC
Build number: none
Revision: 5c9c3bc20ca1c281ac7972643f1e2d190f2c943c
Groovy: 2.3.10
Ant: Apache Ant(TM) version 1.9.4 compiled on April 29 2014
JVM: 1.7.0_79 (Oracle Corporation 24.79-b02)
OS: Windows 7 6.1 amd64
The text was updated successfully, but these errors were encountered: