-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not support renamed output file #46
Comments
Thanks for the report. It seems like this is caused by #32, and we'll need to think harder about how to fix this. |
This fixes a bug wherein the dexcount task fails if the variant's output is renamed after the dexcount plugin is applied and prior to task execution. This also opts dexcount out of Gradle's incremental compilation cache. The proximate cause of this bug is that we're holding a stale `java.io.File` object; the cure is to instead hold a reference to the variant's output. This doesn't work with incremental compliation, because variant output implementations aren't `Serializable` (noted in KeepSafe#32), and Gradle depends on task state being serializable. This mismatch means that dexcount will appear to randomly crash. The least-bad solution is to just remove the task-input annotation, and run the count task every time. Not great, but better than not working. Fixes KeepSafe#40 and KeepSafe#46.
I think this is fixed in the latest snapshot build; would you please try again using |
@benjamin-bader I'd like to. Has this version be published? |
Yes; it has been published to Sonatype's snapshot repo. Instructions for using snapshots are in the readme, let me know if you need help. I'd like to confirm that this fixes the issue before making a final release. |
@benjamin-bader It works. ^_^ |
Nice! Thank you! |
FYI, version 0.4.1 (including this bugfix) is now available in Maven Central, or it will be in an hour or two. |
Build failed if I rename the output file like this:
log:
The text was updated successfully, but these errors were encountered: