Revert #32, remove @Input annotation, add diagnostics
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug wherein the dexcount task fails if the variant's output is renamed after the dexcount plugin is applied and prior to task execution. This also opts dexcount out of Gradle's incremental compilation cache. The proximate cause of this bug is that we're holding a stale `java.io.File` object; the cure is to instead hold a reference to the variant's output. This doesn't work with incremental compliation, because variant output implementations aren't `Serializable` (noted in KeepSafe#32), and Gradle depends on task state being serializable. This mismatch means that dexcount will appear to randomly crash. The least-bad solution is to just remove the task-input annotation, and run the count task every time. Not great, but better than not working. Fixes KeepSafe#40 and KeepSafe#46.
|
Travis is horked, probably due to a corrupted dependency cache. I validated these last night; merging anyways. |
benjamin-bader
added a commit
that referenced
this pull request
Jan 26, 2016
Revert #32, remove `@Input` annotation, add diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40 and #46.