-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For GDMLTube improvement #5
Comments
Thanks but I much prefer to deal with startphi and deltaphi in the procedure angleSectionSolid rather than the individual graphic objects. Then if there is a bug it fixed for all. Also it should deal with startphi which your suggested code did not I do not see/have and problem with the Tube files mentioned, I believe the issue with them |
Hello Keith
Thanks for your answer It is only a suggestion!
I have done downloaded your new code this morning so I am sure that it is the last version. I have the same problem with my two laptops with ou without AppImage. Perhaps you can reproduce the pb with freecad.AppImage. I can 'try' all the gdml files of the deposit on my old laptops with freecad and last gdml version and told you which one are ok or nok. Are you interesting?
Regards Dam
Envoyé depuis mon smartphone Samsung Galaxy.
-------- Message d'origine --------De : Keith Sloan <notifications@github.com> Date : 23/04/2020 16:32 (GMT+01:00) À : KeithSloan/GDML <GDML@noreply.github.com> Cc : lambdam94 <lambdam94@gmail.com>, Author <author@noreply.github.com> Objet : Re: [KeithSloan/GDML] For GDMLTube improvement (#5)
Thanks but I much prefer to deal with startphi and deltaphi in the procedure angleSectionSolid rather than the individual graphic objects. Then if there is a bug it fixed for all. Also it should deal with startphi which your suggested code did not
I do not see/have and problem with the Tube files mentioned, I believe the issue with them
was fixed some commits ago. Please can you check you had the latest code when you experienced the problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "#5 (comment)",
"url": "#5 (comment)",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
Hi Dam Not sure what is going on, the files load fine for me. Do you get any error/console messages. Yes interested in what gdml files do not load. Also one available at https://gitlab.cern.ch/VecGeom/VecGeom/tree/master/persistency/gdml/gdmls |
Hi Keith, the pb is for Freecad0.18.3 (the official ubuntu distribution) I will do other tests on CERN files, Regards
|
By the way are you running Windows or Linux? As to your proposed handling of startphi - I will have to think about as it has a problem in my view. Objects Placement rotation gets exported as a rotation in the associated physical volume. |
I am running under (only) Linux. I am agree with you. |
So think rather than use Placement calls its easier to use
Which is what I tried with latest version of Sphere |
Yes. A rotate without "placement" is better in createGeometry. |
Okay, I altered angleSction so that it worked in my FreeCAD 0.18, give it a try |
Hi Keith, after an erase of GDML module and a new installation (to be sure that Addon give the last version), But, for the sphere, |
Have not fixed the sphere yet. It is work in progress i.e. on a branch on my machine, Hope to make some progress this afternoon. |
Hi Keith, I have done another createGeometry for GDMLTube which needs low memory. Regards `
|
Wonder about the need to check hasattr as it is being done for some variables and not for others. |
I think that variables given by the "outside" should be check. Perharps we should directly refer to the GDML User's guide(lcgapp.cern.ch/project/simu/framework/GDML/doc/GDMLmanual.pdf)
Yes, we are close to be consistent! |
But what the manual refers to is the variables in the GDML file. If all parameters are specified on the init as is the case now, then there is no need to check with hasattr |
Freeing memory. Why is this necessary. Quote from the web
|
Please try latest commit |
That seems good too! The "real" test will be the impact on large file like 'lhcbvelo.gdml'. |
Are you sure your teacher is referring to Python? It is something that should be done for c++, but for Python I don't think del frees any memory, just disassociated the variable. |
Hello Keith,
The SampleFiles/Problem_Files/tube.gdml and SampleFiles/Problem_Files/Tube1000.gdml files can be read if the createGeometry function in GDMLTube(GDMLcommon) is a little modified.
The following python code fixes the problem on my computer.
Regards,
Dam
begin createGeometry class GDMLTube(GDMLcommon) :
def createGeometry(self,fp):
# Need to add code to check values make a valid Tube
# need to take into account startphi != 0.0
# Define six vetices for the shape
mul = GDMLShared.getMult(fp.lunit)
rmax = mul * fp.rmax
rmin = mul * fp.rmin
z = fp.z * mul
end createGeometry class GDMLTube(GDMLcommon) :
The text was updated successfully, but these errors were encountered: