Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues #10

Merged
merged 4 commits into from
May 30, 2020
Merged

Fix build issues #10

merged 4 commits into from
May 30, 2020

Conversation

Paul2708
Copy link
Contributor

The current master branch cannot be built using mvn clean install.
I fixed it by

  • setting UTF-8 as file encoding
  • comment out code with that doesn't compile // TODO: Causing compile errors
  • adding dependency-reduced-pom.xml to .gitignore (doesn't affect the build status but I did it on the fly)

@PXAV PXAV merged commit 66b3733 into KelpFramework:master May 30, 2020
@PXAV
Copy link
Member

PXAV commented May 30, 2020

Thank you for your contribution. Another contributor has already added UTF-8 formatting to the pom file so I removed this change in this pull request. The 1.14 issues will be fixed soon, I still have to figure out some packet constructors that changed from 1.8 :)

@Paul2708 Paul2708 deleted the fix/build-issue branch May 30, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants