Update to Pyo3 0.21 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Emann
force-pushed
the
pyo3_0.21_bound_prep
branch
from
0ade1b3
to
31239e7
Compare
Dr-Emann
force-pushed
the
pyo3_0.21_bound_prep
branch
from
31239e7
to
7649d25
Compare
|
The benchmark appears to show a slight increase in performance for me, mostly when doing @KenanHanke I had to update the CI to fix an issue with the macos build, and while I was at it, I went ahead and took most of the suggested updated CI config from |
[docs](https://pyo3.rs/v0.21.1/performance#extract-versus-downcast) suggest this is faster, and can lead to better error messages in the `bloom.update(bloom)` case: before, `extract::<PyRef<Bloom>>()` would fail, so we would fall back to trying (and failing) to iterate the Bloom object. Now, instead, we get a clear error that `bloom` is already borrowed mutably. We could instead take `&Bound<'_, Bloom>`, and check `slf.is(other)` before borrowing, to avoid the error entirely, but it makes the signature and body of the functions a fair bit uglier, not sure if it's worth it.
Per [maturin PR](PyO3/maturin#1620), use `--target universal2-apple-darwin` instead
Allow gc to collect a Bloom object even if the hash function contains a reference to the Bloom filter We don't have to implement `__clear__`, because our reference is immutable, it will be set in `__new__` and never modified. Reference cycles must include at least one mutable reference, so allow the hash_func object's __clear__ to break the cycle
Dr-Emann
force-pushed
the
pyo3_0.21_bound_prep
branch
from
4f64026
to
be7b67e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pyo3 docs on migrating