Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#70 Linux support for Ubuntu and #72 KP_Enter #71

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Naturalbornhippy
Copy link

@Naturalbornhippy Naturalbornhippy commented Oct 5, 2023

#70 [FEATURE REQUEST] Linux support

  • Change the path of the music folder in music_player.py, which is not the same as in the file system
  • If Statement for Windows Part of setting SetCurrentProcessExplicitAppUserModelID
  • Ignoring notocoloremoji
    [FEAT] Support for K_KP_ENTER: #72 Support for K_KP_ENTER:
  • add the key

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Proposed Changes

  • change path to music instead of Music
  • included platform and check the OS and SetCurrentProcessExplicitAppUserModelID only on Windows
  • fix problem with notocoloremoji font on ubuntu
  • proposal to handle the KP_Enter key as return

Additional Info

  • it would be better to use the correct path, even if it works on windows

Checklist:

  • My code follows the style guidelines of this project and have read CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have checked my code and corrected any misspellings

@Naturalbornhippy Naturalbornhippy changed the title #70 correct pathes in music_player.py #70 Linux support for Ubuntu Oct 6, 2023
@Naturalbornhippy Naturalbornhippy changed the title #70 Linux support for Ubuntu #70 Linux support for Ubuntu and #72 KP_Enter Oct 6, 2023
@Naturalbornhippy Naturalbornhippy marked this pull request as draft October 6, 2023 07:41
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 6, 2023
@Naturalbornhippy
Copy link
Author

Whats the matter with restyled? I have no idea what to fix - sorry :(
Was it already in the code base? can i support to get it green? :)

And can someone perform an Test on Windows?

@KendallDoesCoding
Copy link
Owner

Hi,

Will check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants