ProofHandle Improvements #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredmoody
force-pushed
the
proof-handles-improvements
branch
from
0da1943
to
4e65dc6
Compare
|
@KenjiOhtsuka Can you review this soon? I'd like to use the updated ProofHandle interface in my project. Thanks! |
spec/proof_handle_spec.rb
Outdated
| let(:node_hash_id) { 'fa07e250-535f-11e9-833f-01d2112f8dc2' } | ||
|
|
||
| describe '#initialize' do | ||
| subject(:initialize!) { Chainpoint::ProofHandle.new(uri, node_hash_id) } |
There was a problem hiding this comment.
I have a question.
At the sixth line in spec/hash_spec.rb, described_class is used, but here, you use Chainpoint::ProofHandle.
Which do you think is better?
Also allow setting of proof handles directly, not just in initializer
jaredmoody
force-pushed
the
proof-handles-improvements
branch
from
4e65dc6
to
2bd129f
Compare
|
Hmm I would have thought rubocop should have caught that. Anyway the second initialization was redundant, so I removed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.