Make SIUnits compatible with Gadfly #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 4, 2015 18:16
DualNumbers.jl (used by Gadfly) and SIUnits declare ambiguous isless function. Since isless is only meaningfull for real numbers, and since both DualNumbers and SIUnit declare it for Number rather than Real arguments, the trick is for SIUnit to downgrade its declaration to the more specific type. Number is a supertype of both Real and Complex.
|
LGTM |
Keno
added a commit
that referenced
this pull request
Sep 11, 2015
Make SIUnits compatible with Gadfly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point is to be able to plot quantities with units:
The example above issues warnings about function clashes with a
*in Compose andislessin DualNumbers, both used by Gadfly.This pull-request corrects both issues by declaring the functions with more specific types.
This pull-request would close #19.