Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 243 migrate transformation analyzer #296

Merged
merged 8 commits into from
Aug 1, 2019
Merged

Issue 243 migrate transformation analyzer #296

merged 8 commits into from
Aug 1, 2019

Conversation

yuriys-kentico
Copy link
Contributor

@yuriys-kentico yuriys-kentico commented Jul 29, 2019 •
edited by ChristopherJennings
Loading

Motivation

Migrate the Transformation analyzer module to a new V4 report (#243)

Added ResultsHelper which uses Environment.NewLine. This might not be necessary as it depends on the CSS in the frontend.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)

ChristopherJennings
ChristopherJennings suggested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@ChristopherJennings ChristopherJennings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good. Please take a look at the comments and adjust accordingly. It's mostly minor naming/formatting things. And many are largely optional. Let me know when you've had enough and consider it ready to go. 😉

KenticoInspector.Core/Helpers/ResultsHelper.cs Outdated Show resolved Hide resolved
KenticoInspector.Core/Helpers/ResultsHelper.cs Outdated Show resolved Hide resolved
KenticoInspector.Core/Helpers/ResultsHelper.cs Outdated Show resolved Hide resolved
KenticoInspector.Reports.Tests/TransformationSecurityAnalysisTests.cs Outdated Show resolved Hide resolved
KenticoInspector.Reports.Tests/TransformationSecurityAnalysisTests.cs Outdated Show resolved Hide resolved
KenticoInspector.Reports/TransformationSecurityAnalysis/Constants/XmlConstants.cs Outdated Show resolved Hide resolved
KenticoInspector.Reports/TransformationSecurityAnalysis/IssueAnalyzers.cs Show resolved Hide resolved
KenticoInspector.Reports/TransformationSecurityAnalysis/Metadata/en-US.yaml Show resolved Hide resolved
KenticoInspector.Reports/TransformationSecurityAnalysis/Report.cs Outdated Show resolved Hide resolved
KenticoInspector.Reports/TransformationSecurityAnalysis/Report.cs Outdated Show resolved Hide resolved
@ChristopherJennings ChristopherJennings merged commit a3a12cb into Kentico:master Aug 1, 2019
@yuriys-kentico yuriys-kentico deleted the issue-243-migrate-transformation-analyzer branch August 1, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherJennings ChristopherJennings ChristopherJennings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuriys-kentico @ChristopherJennings