-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/issue 41 #44
Merged
Merged
Fix/issue 41 #44
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e5b780c
Merge branch 'release/0.11.0'
1a411ff
Merge branch 'release/0.12.0'
pm3310 b8563d6
Added docs for "docker_tag" method option. Fixed two docs typos.
ilazakis 61edbfd
Removed redundant "latest" docker tag suffix.
ilazakis b37d129
Added tests for cases where a docker tag is passed to the "sagify clo…
ilazakis 09279ac
Added more instances of missing docs for "docker_tag".
ilazakis 40233e6
Exclude ASCII logo and standard directories and files from linting.
ilazakis ca805da
Exclude .eggs subdirectories too.
ilazakis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
docker_tag
work earlier this year sets the latest docker tag by default unless otherwise specified by the user i.e. there is no need to hardcode it here. This was actually causing image names of theimage-name:some-tag:latest
form to be used, thatDocker
andSageMaker
declined.