-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/issue 41 #44
Fix/issue 41 #44
Conversation
…ud train" and "sagify cloud deploy" commands.
@@ -158,7 +158,7 @@ def _construct_image_location(self, image_name): | |||
account = self.boto_session.client('sts').get_caller_identity()['Account'] | |||
region = self.boto_session.region_name | |||
|
|||
return '{account}.dkr.ecr.{region}.amazonaws.com/{image}:latest'.format( | |||
return '{account}.dkr.ecr.{region}.amazonaws.com/{image}'.format( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docker_tag
work earlier this year sets the latest docker tag by default unless otherwise specified by the user i.e. there is no need to hardcode it here. This was actually causing image names of the image-name:some-tag:latest
form to be used, that Docker
and SageMaker
declined.
Hey @ilazakis, it LGTM :-D Great work. You just need to fix some linting issues
flake8 doesn't like the ascii logo in the Check this out how to ignore this linting issue http://flake8.pycqa.org/en/3.1.1/user/ignoring-errors.html#in-line-ignoring-errors |
@pm3310 Updated to exclude the ASCII logo file plus a number or usual suspects ala |
What
docker_tag
option.