Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 41 #44

Merged
merged 8 commits into from
Nov 5, 2018
Merged

Fix/issue 41 #44

merged 8 commits into from
Nov 5, 2018

Conversation

ilazakis
Copy link
Contributor

@ilazakis ilazakis commented Nov 3, 2018

What

  1. Fixes issue 'trainingJobName' failed to satisfy constraint #41
  2. Corrects a couple of docs typos and adds missing doc entries for docker_tag option.

@ilazakis ilazakis requested a review from pm3310 November 3, 2018 19:52
@@ -158,7 +158,7 @@ def _construct_image_location(self, image_name):
account = self.boto_session.client('sts').get_caller_identity()['Account']
region = self.boto_session.region_name

return '{account}.dkr.ecr.{region}.amazonaws.com/{image}:latest'.format(
return '{account}.dkr.ecr.{region}.amazonaws.com/{image}'.format(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docker_tag work earlier this year sets the latest docker tag by default unless otherwise specified by the user i.e. there is no need to hardcode it here. This was actually causing image names of the image-name:some-tag:latest form to be used, that Docker and SageMaker declined.

@pm3310
Copy link
Contributor

pm3310 commented Nov 4, 2018

Hey @ilazakis, it LGTM :-D Great work. You just need to fix some linting issues

$ make lint
flake8
./sagify/commands/__init__.py:8:-153: W605 invalid escape sequence '\_'
./sagify/commands/__init__.py:8:-148: W605 invalid escape sequence '\ '
./sagify/commands/__init__.py:8:-74: W605 invalid escape sequence '\_'
./sagify/commands/__init__.py:8:-68: W605 invalid escape sequence '\_'
./sagify/commands/__init__.py:8:-56: W605 invalid escape sequence '\_'

flake8 doesn't like the ascii logo in the commands/__init__.py but you can ignore it.

Check this out how to ignore this linting issue http://flake8.pycqa.org/en/3.1.1/user/ignoring-errors.html#in-line-ignoring-errors

@ilazakis
Copy link
Contributor Author

ilazakis commented Nov 5, 2018

@pm3310 Updated to exclude the ASCII logo file plus a number or usual suspects ala .git etc

@ilazakis ilazakis merged commit 376b2d5 into Kenza-AI:develop Nov 5, 2018
@ilazakis ilazakis deleted the fix/issue-41 branch November 5, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants