Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the report section, the first char of handler names are missing #583

Closed
liamlaverty opened this issue Feb 14, 2024 · 0 comments
Closed

In the report section, the first char of handler names are missing #583

liamlaverty opened this issue Feb 14, 2024 · 0 comments

Comments

@liamlaverty
Copy link
Contributor

Describe the bug
In the report section, the first char of item names are missing:

To Reproduce
Steps to reproduce the behavior:

  1. Go to usync dashboard
  2. Click Content -> Report
  3. Review the list of handlers

Expected behavior
Full name of handlers

Screenshots
image

image

About your Site (please complete the following information):

  • Umbraco Version: 13.1.1
  • uSync Version: 13.0.1
  • Browser Firefox & Edge

Additional context
I think it's happening here: https://github.com/KevinJump/uSync/blame/d4c5e432ef7b37e483c638d508a13e657d72b252/uSync.Backoffice.Assets/App_Plugins/uSync/components/usync.reportview.component.js#L109

Probably to remove the I from the start of interfaces like IMedia -> Media?
liamlaverty added a commit to liamlaverty/uSync that referenced this issue Feb 14, 2024
@liamlaverty
KevinJump#583 - removes .substring(1) from handler names
4c6289e 
see KevinJump#583
@liamlaverty liamlaverty mentioned this issue Feb 14, 2024
Merged
KevinJump pushed a commit that referenced this issue Feb 14, 2024
@liamlaverty
#583 - removes .substring(1) from handler names (#584)
bd7a593 
see #583
KevinJump added a commit that referenced this issue Feb 16, 2024
@KevinJump @liamlaverty
merge v13 changes into v14 branch. (#585)
77ee1a1 
* roots - part 1. wip.

* Sort the generic properties correctly on xml merge.

* merging properties.

* generic - image cropper.

* Add all the stops.

* Add settings to the settings box.

* make sure deletes when the key is a string work on merge.

* Make status checks - check all folders.

* fix missing null check on callbacks., causing firstboot to fail.

* some logging around first boot.

* moving controllers to .assets project (prepping core for multi-targeting)

* fix for the stylesheet toobar name changing. (#578)

* fix for the stylesheet toobar name changing.

* Add extra check incase 'toolbar' is missing

* Add RTE null check when editor config is missing.

* Make it all less breaking.

* experimental: background notification threading.

* Exeuction flow around background task (as per core)

* top and tail the ordering message, so it looks like things are indeed happening.

* Background threding, and state events.

* least best breaking changes.

* build action

* All branches

* Duplicate checking.

* chgore: schema file update

* #583 - removes `.substring(1)` from handler names (#584)

see #583

* Fix - compatability - mark field setters as obsolete

---------

Co-authored-by: Liam Laverty <liamlaverty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KevinJump @liamlaverty