#583 - removes .substring(1) from handler names
#584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, i suspect its all legacy, and there are no I interfacing being used anymore. |
KevinJump
added a commit
that referenced
this pull request
Feb 16, 2024
* roots - part 1. wip. * Sort the generic properties correctly on xml merge. * merging properties. * generic - image cropper. * Add all the stops. * Add settings to the settings box. * make sure deletes when the key is a string work on merge. * Make status checks - check all folders. * fix missing null check on callbacks., causing firstboot to fail. * some logging around first boot. * moving controllers to .assets project (prepping core for multi-targeting) * fix for the stylesheet toobar name changing. (#578) * fix for the stylesheet toobar name changing. * Add extra check incase 'toolbar' is missing * Add RTE null check when editor config is missing. * Make it all less breaking. * experimental: background notification threading. * Exeuction flow around background task (as per core) * top and tail the ordering message, so it looks like things are indeed happening. * Background threding, and state events. * least best breaking changes. * build action * All branches * Duplicate checking. * chgore: schema file update * #583 - removes `.substring(1)` from handler names (#584) see #583 * Fix - compatability - mark field setters as obsolete --------- Co-authored-by: Liam Laverty <liamlaverty@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #583
I'm uncertain if it's OK to just remove the line of code, as there may still be interfaces to remove the
Ifrom.