Skip to content

Commit

Permalink
Changes and enhancements for production release (#6) (#7)
Browse files Browse the repository at this point in the history
* Inventory Working
* Final Enrollment works
* Prod Ready Fixes
* add pam support with updated extension framework
* invoke reenrollment from job delegate; build class logger instead of ctor arg (arg can't be resolved by framework correctly)
* use subject from reenrollment job
* break cert request payload into conditional sections
* use SSL setting to select https
* use cert name (alias) and certusage from entry parameters
* use constants for APIs and Cert Usage codes
* only delete cert on reenrollment with Overwrite specified
* add error logging and method logging
* add API request trace logging + update methods to use object types instead of string
* safe check required fields present in job props

Co-authored-by: Matthew Dobrowsky <11599974+doebrowsk@users.noreply.github.com>
  • Loading branch information
fiddlermikey and doebrowsk committed Jul 13, 2023
1 parent 75ae784 commit 22a9b0c
Show file tree
Hide file tree
Showing 31 changed files with 1,478 additions and 1,385 deletions.
26 changes: 23 additions & 3 deletions .github/workflows/keyfactor-starter-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,42 @@ jobs:
call-create-github-release-workflow:
uses: Keyfactor/actions/.github/workflows/github-release.yml@main

get-manifest-properties:
runs-on: windows-latest
outputs:
update_catalog: ${{ steps.read-json.outputs.update_catalog }}
integration_type: ${{ steps.read-json.outputs.integration_type }}
steps:
- uses: actions/checkout@v3
- name: Store json
id: read-json
shell: pwsh
run: |
$json = Get-Content integration-manifest.json | ConvertFrom-Json
$myvar = $json.update_catalog
echo "update_catalog=$myvar" | Out-File -FilePath $Env:GITHUB_OUTPUT -Encoding utf8 -Append
$myvar = $json.integration_type
echo "integration_type=$myvar" | Out-File -FilePath $Env:GITHUB_OUTPUT -Encoding utf8 -Append
call-dotnet-build-and-release-workflow:
needs: [call-create-github-release-workflow]
uses: Keyfactor/actions/.github/workflows/dotnet-build-and-release.yml@main
with:
release_version: ${{ needs.call-create-github-release-workflow.outputs.release_version }}
release_url: ${{ needs.call-create-github-release-workflow.outputs.release_url }}
release_dir: BoschIPCamera/bin/Release/netcoreapp3.1 # TODO: set build output directory to upload as a release, relative to checkout workspace
release_dir: BoschIPCamera/bin/Release/netcoreapp3.1
secrets:
token: ${{ secrets.PRIVATE_PACKAGE_ACCESS }}

call-generate-readme-workflow:
if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'
uses: Keyfactor/actions/.github/workflows/generate-readme.yml@main
secrets:
token: ${{ secrets.APPROVE_README_PUSH }}

call-update-catalog-workflow:
if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'
needs: get-manifest-properties
if: needs.get-manifest-properties.outputs.update_catalog == 'True' && (github.event_name == 'push' || github.event_name == 'workflow_dispatch')
uses: Keyfactor/actions/.github/workflows/update-catalog.yml@main
secrets:
token: ${{ secrets.SDK_SYNC_PAT }}
token: ${{ secrets.SDK_SYNC_PAT }}
2 changes: 1 addition & 1 deletion BoschIPCamera/BoschIPCamera.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

<ItemGroup>
<PackageReference Include="Keyfactor.Logging" Version="1.1.1" />
<PackageReference Include="Keyfactor.Orchestrators.IOrchestratorJobExtensions" Version="0.6.0" />
<PackageReference Include="Keyfactor.Orchestrators.IOrchestratorJobExtensions" Version="0.7.0" />
<PackageReference Include="System.Management.Automation" Version="7.0.5" />
<PackageReference Include="RestSharp" Version="107.2.1" />
<PackageReference Include="RestSharp.Authenticators.Digest" Version="1.3.1" />
Expand Down
Loading

0 comments on commit 22a9b0c

Please sign in to comment.