Changes and enhancements for production release #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build class logger instead of ctor arg (arg can't be resolved by framework correctly)
fiddlermikey
requested changes
Jul 6, 2023
There was a problem hiding this comment.
@doebrowsk : BoschIPCameraTestConsole\Program.cs missing Apache license header and has many todo statements that should be removed. Or the TestConsole should be removed entirely
Otherwise, this looks good
fiddlermikey
approved these changes
Jul 13, 2023
fiddlermikey
added a commit
that referenced
this pull request
Jul 13, 2023
* Inventory Working * Final Enrollment works * Prod Ready Fixes * add pam support with updated extension framework * invoke reenrollment from job delegate; build class logger instead of ctor arg (arg can't be resolved by framework correctly) * use subject from reenrollment job * break cert request payload into conditional sections * use SSL setting to select https * use cert name (alias) and certusage from entry parameters * use constants for APIs and Cert Usage codes * only delete cert on reenrollment with Overwrite specified * add error logging and method logging * add API request trace logging + update methods to use object types instead of string * safe check required fields present in job props Co-authored-by: Matthew Dobrowsky <11599974+doebrowsk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.