Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[index] finish keyvimerger integration as part of the python package #38

Merged
merged 7 commits into from
Feb 14, 2018

Conversation

hendrikmuhs
Copy link
Contributor

with this PR the python package is fully self-contained again. keyvimerger already shipped with the package but the code in the C++ part was missing.

@hendrikmuhs
Copy link
Contributor Author

removing make install broke C++ unit tests. But I consider this a good thing. Tests should run without running make install first, i somehow need to inject the keyvimerger binary location like for the python tests.

@coveralls
Copy link

coveralls commented Feb 13, 2018

Coverage Status

Coverage increased (+0.02%) to 93.186% when pulling 0df5f31 on hendrikmuhs:index-keyvimerger-python into d308d2e on KeyviDev:index.

@hendrikmuhs
Copy link
Contributor Author

to be reviewed as part of #37

@hendrikmuhs hendrikmuhs merged commit 1037513 into KeyviDev:index Feb 14, 2018
@narekgharibyan narekgharibyan mentioned this pull request Feb 22, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants