Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with deleted keys on index reload and lazy loading #62

Merged
merged 3 commits into from
Mar 27, 2018

Conversation

hendrikmuhs
Copy link
Contributor

Fix an issue that deleted keys were not loaded correctly on index reload from disk. Also fixes lazy loading for segments in writer.

always load writer segments lazy, create writer segments without deletions,
fix issue that triggered loading of segments in writer on merge checks.
@coveralls
Copy link

coveralls commented Mar 23, 2018

Coverage Status

Coverage decreased (-0.2%) to 93.548% when pulling 5757f7b on hendrikmuhs:fix-delete-reload into 3570797 on KeyviDev:master.

Copy link
Member

@narekgharibyan narekgharibyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrikmuhs hendrikmuhs merged commit ea2a699 into KeyviDev:master Mar 27, 2018
@hendrikmuhs hendrikmuhs deleted the fix-delete-reload branch April 5, 2020 13:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants