Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement fragment dynamic #170

Closed
wants to merge 5 commits into from
Closed

Implement fragment dynamic #170

wants to merge 5 commits into from

Conversation

NuVivo314
Copy link
Contributor

This proposal.

The problem: Who make query dynamic return.
Solution: The dynamic fragment.

@NuVivo314 NuVivo314 marked this pull request as ready for review February 7, 2022 18:35
@NuVivo314 NuVivo314 changed the title implement fragment dynamic Implement fragment dynamic Feb 8, 2022
benjaminjkraft
benjaminjkraft requested changes Feb 9, 2022
View reviewed changes
Copy link
Collaborator

@benjaminjkraft benjaminjkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Again here I'd like to understand what it is you're trying to do -- in this case just reading the code didn't even give me a very good idea of what it does -- something about dynamically constructed queries? -- nor why you might want it. Could you fill that in a bit more? Perhaps both some more explanation of your use case, and/or some snapshot and integration tests -- we'll need those eventually anyway to merge.

benjaminjkraft added a commit that referenced this pull request Feb 10, 2022
@benjaminjkraft
Release v0.4.0
683f324 
It's been a while, time for a release!  This commit updates the
changelog, and I'll tag it with the release once it lands.

Fixes #163.  I'll wait for #169 and #170 to land before merging this.

Test plan: Craig tested a fairly recent main branch in webapp.
@benjaminjkraft benjaminjkraft mentioned this pull request Feb 10, 2022
Merged
6 tasks
@NuVivo314 NuVivo314 mentioned this pull request Feb 12, 2022
Merged
@csilvers csilvers removed their request for review March 1, 2022 17:36
@benjaminjkraft benjaminjkraft added the needs more info Blocked until requester provides more information; may be closed after a while label Apr 29, 2022
@NuVivo314
Copy link
Contributor Author

Hello, i close this. Is very complex and don't add value.

@NuVivo314 NuVivo314 closed this Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminjkraft benjaminjkraft benjaminjkraft requested changes

@dnerdy dnerdy Awaiting requested review from dnerdy dnerdy is a code owner

@StevenACoffman StevenACoffman Awaiting requested review from StevenACoffman StevenACoffman is a code owner

Assignees
No one assigned
Labels
needs more info Blocked until requester provides more information; may be closed after a while
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NuVivo314 @benjaminjkraft