Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.4.0 #163

Closed
suhabe opened this issue Jan 15, 2022 · 8 comments · Fixed by #174
Closed

release 0.4.0 #163

suhabe opened this issue Jan 15, 2022 · 8 comments · Fixed by #174

Comments

@suhabe
Copy link

suhabe commented Jan 15, 2022

It would be helpful to bump gqlgen to 0.15.0 and to release a new version of genqlient.

@suhabe suhabe added the enhancement New feature or request label Jan 15, 2022
@benjaminjkraft benjaminjkraft changed the title new release release 0.15.0 Jan 21, 2022
@benjaminjkraft
Copy link
Collaborator

benjaminjkraft commented Jan 21, 2022

Thanks for the poke! I've been meaning to cut a release but haven't gotten around to it. Some things we need to do:

@benjaminjkraft benjaminjkraft removed the enhancement New feature or request label Jan 21, 2022
@benjaminjkraft benjaminjkraft changed the title release 0.15.0 release 0.4.0 Jan 21, 2022
@benjaminjkraft
Copy link
Collaborator

By the way, what's the reason to bump gqlgen? It's not really used by the production-facing parts of genqlient, so I'm not sure if there's a reason for us to force folks to upgrade.

@csilvers
Copy link
Member

Land Allow the use of typename to be combined with bind. #138 (or decide we're not going to)

I think last discussion I was leaning toward "decide we're not going to" -- I'm fine with that.

Ideally if someone at Khan or another big codebase using genqlient has a chance to test recent main branch, that would be great.

We're currently using a52e556, I can try using main. We're in crunch time porting graphql-gateway to go (!) but I'll see if I can squeeze this in.

@csilvers
Copy link
Member

I think last discussion I was leaning toward "decide we're not going to" -- I'm fine with that.

In particular, I think the best course is to check for typename with bind and explicitly disallow it (which work has not yet been done).

@benjaminjkraft
Copy link
Collaborator

Ok, thanks! I won't get to do the release until at least next week anyway, and if you don't have time it's not a huge deal since I think at least two other users have tested #155 which is the biggest change since a52e556.

@csilvers
Copy link
Member

I did manage to test the new genqlient on our codebase. All the tests pass at least! We won't be able to try it out in production until monday at the earliest though.

@csilvers
Copy link
Member

csilvers commented Feb 2, 2022

@benjaminjkraft : we've been using the new genqlient in production for a few days now with no reported issues.

@benjaminjkraft
Copy link
Collaborator

Thanks! I'll get on the rest of the items above tomorrow if I have time, or next week if not!

benjaminjkraft added a commit that referenced this issue Feb 10, 2022
It's been a while, time for a release!  This commit updates the
changelog, and I'll tag it with the release once it lands.

Fixes #163.  I'll wait for #169 and #170 to land before merging this.

Test plan: Craig tested a fairly recent main branch in webapp.
@benjaminjkraft benjaminjkraft mentioned this issue Feb 10, 2022
6 tasks
benjaminjkraft added a commit that referenced this issue Feb 10, 2022
It's been a while, time for a release! This commit updates the
changelog including a few missing entries, and I'll tag it with
the release once it lands.

Fixes #163 

Test plan: Craig tested a fairly recent main branch in webapp.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants