Add some more tests for config validation, and fix some gaps #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I set these tests up in #270, but I realized there's a lot more we could test unrelated to that PR. In this commit I add some more tests. They're not really exhaustive yet, but they did catch a few bugs, which I fixed: - we weren't validating the package-name if you do set it (only if we guess it) - If you omitted `generated`, you would try to write generated code to the directory containing `genqlient.yaml`, which makes no sense; now we default to `generated.go`. In the real world it's probably good to set explicitly, but it's actually very convenient in tests that we don't have to, and maybe in small projects too.
benjaminjkraft
requested review from
csilvers,
dnerdy and
StevenACoffman
as code owners
dmitryax
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Mar 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/Khan/genqlient](https://togithub.com/Khan/genqlient) | `v0.6.0` -> `v0.7.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>Khan/genqlient (github.com/Khan/genqlient)</summary> ### [`v0.7.0`](https://togithub.com/Khan/genqlient/releases/tag/v0.7.0) [Compare Source](https://togithub.com/Khan/genqlient/compare/v0.6.0...v0.7.0) In addition to several new features and bugfixes, along with this release comes reorganized [documentation](https://togithub.com/Khan/genqlient/blob/main/docs) for genqlient. Note that genqlient now requires Go 1.20 or higher, and is tested through Go 1.22. #### What's Changed - Add "generic" option to the "optional" configuration for handling nullable types by [@​DylanRJohnston](https://togithub.com/DylanRJohnston) in [Khan/genqlient#252 - Documentation tweaks relating to releases by [@​benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#271 - Add some better tests for use_struct_references by [@​benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#273 - Add an option to handle enums with ugly casing by [@​benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#270 - Add some more tests for config validation, and fix some gaps by [@​benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#274 - Add consideration for pointer false directive when optional: pointer configuration option is used by [@​spencermurray](https://togithub.com/spencermurray) in [Khan/genqlient#280 - Update gqlparser and gqlgen dependencies by [@​StevenACoffman](https://togithub.com/StevenACoffman) in [Khan/genqlient#282 - Update gqlparser to omit comments by [@​StevenACoffman](https://togithub.com/StevenACoffman) in [Khan/genqlient#284 - bugfix: local variable 'data' colliding with argument name by [@​zholti](https://togithub.com/zholti) in [Khan/genqlient#291 - Pin lint workflow's Go version by [@​benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#311 - Upgrade golangci-lint and which go we run it with by [@​benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#314 - fix implementation type generation for fragment on a union by [@​zzh8829](https://togithub.com/zzh8829) in [Khan/genqlient#310 - Support more valid graphql file extensions by [@​zzh8829](https://togithub.com/zzh8829) in [Khan/genqlient#309 - Add tests on Go 1.22, and upgrade x/tools to make them work by [@​benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#315 - Update gqlgen to latest by [@​StevenACoffman](https://togithub.com/StevenACoffman) in [Khan/genqlient#317 - move genqlient Go module to 1.20 by [@​StevenACoffman](https://togithub.com/StevenACoffman) in [Khan/genqlient#318 - Improve package-sniffing and bind correctly to types in the same package by [@​benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#316 - Reorganize and improve documentation by [@​benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#322 - Fix non-deterministic generated code involving interfaces and fragments. by [@​csilvers](https://togithub.com/csilvers) in [Khan/genqlient#323 - Release v0.7.0 by [@​benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#324 #### New Contributors - [@​DylanRJohnston](https://togithub.com/DylanRJohnston) made their first contribution in [Khan/genqlient#252 - [@​spencermurray](https://togithub.com/spencermurray) made their first contribution in [Khan/genqlient#280 - [@​zholti](https://togithub.com/zholti) made their first contribution in [Khan/genqlient#291 - [@​zzh8829](https://togithub.com/zzh8829) made their first contribution in [Khan/genqlient#310 **Full Changelog**: Khan/genqlient@v0.6.0...v0.7.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/Khan/genqlient](https://togithub.com/Khan/genqlient) | `v0.6.0` -> `v0.7.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>Khan/genqlient (github.com/Khan/genqlient)</summary> ### [`v0.7.0`](https://togithub.com/Khan/genqlient/releases/tag/v0.7.0) [Compare Source](https://togithub.com/Khan/genqlient/compare/v0.6.0...v0.7.0) In addition to several new features and bugfixes, along with this release comes reorganized [documentation](https://togithub.com/Khan/genqlient/blob/main/docs) for genqlient. Note that genqlient now requires Go 1.20 or higher, and is tested through Go 1.22. #### What's Changed - Add "generic" option to the "optional" configuration for handling nullable types by [@&open-telemetry#8203;DylanRJohnston](https://togithub.com/DylanRJohnston) in [Khan/genqlient#252 - Documentation tweaks relating to releases by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#271 - Add some better tests for use_struct_references by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#273 - Add an option to handle enums with ugly casing by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#270 - Add some more tests for config validation, and fix some gaps by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#274 - Add consideration for pointer false directive when optional: pointer configuration option is used by [@&open-telemetry#8203;spencermurray](https://togithub.com/spencermurray) in [Khan/genqlient#280 - Update gqlparser and gqlgen dependencies by [@&open-telemetry#8203;StevenACoffman](https://togithub.com/StevenACoffman) in [Khan/genqlient#282 - Update gqlparser to omit comments by [@&open-telemetry#8203;StevenACoffman](https://togithub.com/StevenACoffman) in [Khan/genqlient#284 - bugfix: local variable 'data' colliding with argument name by [@&open-telemetry#8203;zholti](https://togithub.com/zholti) in [Khan/genqlient#291 - Pin lint workflow's Go version by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#311 - Upgrade golangci-lint and which go we run it with by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#314 - fix implementation type generation for fragment on a union by [@&open-telemetry#8203;zzh8829](https://togithub.com/zzh8829) in [Khan/genqlient#310 - Support more valid graphql file extensions by [@&open-telemetry#8203;zzh8829](https://togithub.com/zzh8829) in [Khan/genqlient#309 - Add tests on Go 1.22, and upgrade x/tools to make them work by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#315 - Update gqlgen to latest by [@&open-telemetry#8203;StevenACoffman](https://togithub.com/StevenACoffman) in [Khan/genqlient#317 - move genqlient Go module to 1.20 by [@&open-telemetry#8203;StevenACoffman](https://togithub.com/StevenACoffman) in [Khan/genqlient#318 - Improve package-sniffing and bind correctly to types in the same package by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#316 - Reorganize and improve documentation by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#322 - Fix non-deterministic generated code involving interfaces and fragments. by [@&open-telemetry#8203;csilvers](https://togithub.com/csilvers) in [Khan/genqlient#323 - Release v0.7.0 by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#324 #### New Contributors - [@&open-telemetry#8203;DylanRJohnston](https://togithub.com/DylanRJohnston) made their first contribution in [Khan/genqlient#252 - [@&open-telemetry#8203;spencermurray](https://togithub.com/spencermurray) made their first contribution in [Khan/genqlient#280 - [@&open-telemetry#8203;zholti](https://togithub.com/zholti) made their first contribution in [Khan/genqlient#291 - [@&open-telemetry#8203;zzh8829](https://togithub.com/zzh8829) made their first contribution in [Khan/genqlient#310 **Full Changelog**: Khan/genqlient@v0.6.0...v0.7.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/Khan/genqlient](https://togithub.com/Khan/genqlient) | `v0.6.0` -> `v0.7.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>Khan/genqlient (github.com/Khan/genqlient)</summary> ### [`v0.7.0`](https://togithub.com/Khan/genqlient/releases/tag/v0.7.0) [Compare Source](https://togithub.com/Khan/genqlient/compare/v0.6.0...v0.7.0) In addition to several new features and bugfixes, along with this release comes reorganized [documentation](https://togithub.com/Khan/genqlient/blob/main/docs) for genqlient. Note that genqlient now requires Go 1.20 or higher, and is tested through Go 1.22. #### What's Changed - Add "generic" option to the "optional" configuration for handling nullable types by [@&open-telemetry#8203;DylanRJohnston](https://togithub.com/DylanRJohnston) in [Khan/genqlient#252 - Documentation tweaks relating to releases by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#271 - Add some better tests for use_struct_references by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#273 - Add an option to handle enums with ugly casing by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#270 - Add some more tests for config validation, and fix some gaps by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#274 - Add consideration for pointer false directive when optional: pointer configuration option is used by [@&open-telemetry#8203;spencermurray](https://togithub.com/spencermurray) in [Khan/genqlient#280 - Update gqlparser and gqlgen dependencies by [@&open-telemetry#8203;StevenACoffman](https://togithub.com/StevenACoffman) in [Khan/genqlient#282 - Update gqlparser to omit comments by [@&open-telemetry#8203;StevenACoffman](https://togithub.com/StevenACoffman) in [Khan/genqlient#284 - bugfix: local variable 'data' colliding with argument name by [@&open-telemetry#8203;zholti](https://togithub.com/zholti) in [Khan/genqlient#291 - Pin lint workflow's Go version by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#311 - Upgrade golangci-lint and which go we run it with by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#314 - fix implementation type generation for fragment on a union by [@&open-telemetry#8203;zzh8829](https://togithub.com/zzh8829) in [Khan/genqlient#310 - Support more valid graphql file extensions by [@&open-telemetry#8203;zzh8829](https://togithub.com/zzh8829) in [Khan/genqlient#309 - Add tests on Go 1.22, and upgrade x/tools to make them work by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#315 - Update gqlgen to latest by [@&open-telemetry#8203;StevenACoffman](https://togithub.com/StevenACoffman) in [Khan/genqlient#317 - move genqlient Go module to 1.20 by [@&open-telemetry#8203;StevenACoffman](https://togithub.com/StevenACoffman) in [Khan/genqlient#318 - Improve package-sniffing and bind correctly to types in the same package by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#316 - Reorganize and improve documentation by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#322 - Fix non-deterministic generated code involving interfaces and fragments. by [@&open-telemetry#8203;csilvers](https://togithub.com/csilvers) in [Khan/genqlient#323 - Release v0.7.0 by [@&open-telemetry#8203;benjaminjkraft](https://togithub.com/benjaminjkraft) in [Khan/genqlient#324 #### New Contributors - [@&open-telemetry#8203;DylanRJohnston](https://togithub.com/DylanRJohnston) made their first contribution in [Khan/genqlient#252 - [@&open-telemetry#8203;spencermurray](https://togithub.com/spencermurray) made their first contribution in [Khan/genqlient#280 - [@&open-telemetry#8203;zholti](https://togithub.com/zholti) made their first contribution in [Khan/genqlient#291 - [@&open-telemetry#8203;zzh8829](https://togithub.com/zzh8829) made their first contribution in [Khan/genqlient#310 **Full Changelog**: Khan/genqlient@v0.6.0...v0.7.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set these tests up in #270, but I realized there's a lot more we could test unrelated to that PR. In this commit I add some more tests. They're not really exhaustive yet, but they did catch a few bugs, which I fixed:
generated, you would try to write generated code to the directory containinggenqlient.yaml, which makes no sense; now we default togenerated.go. In the real world it's probably good to set explicitly, but it's actually very convenient in tests that we don't have to, and maybe in small projects too.I have: