Make README logo work in dark mode #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminjkraft
requested review from
dangoor,
dbraley,
dnerdy and
kevinbarabash
|
Fancy solution! Works well for me. I switched my Mac from dark mode to light mode, and could see the difference with a page reload. |
dangoor
approved these changes
Sep 10, 2021
dbraley
approved these changes
Sep 10, 2021
benjaminjkraft
force-pushed
the
benkraft.docs-3
branch
from
6709c1e
to
7289b85
Compare
benjaminjkraft
force-pushed
the
benkraft.docs-4
branch
from
86b88d7
to
dca3378
Compare
benjaminjkraft
force-pushed
the
benkraft.docs-3
branch
from
7289b85
to
e8d24f1
Compare
Dark mode is, they say, the new thing, and the logo doesn't work super well with it, because it's black on dark grey. This is surprisingly hard to fix. There are a few options: - make the logo colored; sorry, but I like black - add a white border to the logo; this is what Apollo does but I think it's pretty ugly in dark mode - add svg with media queries; this works well but only if the github dark mode setting matches the browser(/OS) dark mode setting, since that's what the media queries look at I opted for option 3. This required converting the text in the SVG to paths, since it really matters that you have the exact same font. (I tested on Android Firefox, which empirically doesn't have the same fonts I have on desktop.) Fixes #17. Issue: #17 Test plan: tested that it looks good on both mobile firefox in dark mode, and desktop firefox+chrome in light mode. Reviewers: dbraley, kevinb, kevindangoor, marksandstrom
benjaminjkraft
force-pushed
the
benkraft.docs-4
branch
from
dca3378
to
ecf2d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Dark mode is, they say, the new thing, and the logo doesn't work super
well with it, because it's black on dark grey. This is surprisingly
hard to fix. There are a few options:
think it's pretty ugly in dark mode
dark mode setting matches the browser(/OS) dark mode setting, since
that's what the media queries look at
I opted for option 3. This required converting the text in the SVG to
paths, since it really matters that you have the exact same font. (I
tested on Android Firefox, which empirically doesn't have the same fonts
I have on desktop.)
Fixes #17.
Issue: #17
Test plan:
tested that it looks good on both mobile firefox in dark mode, and
desktop firefox+chrome in light mode.