Conversation
The ports are still fairly rough, I need to go back and take a second look at them, but I wanted to get this review started. One problem I know for sure exists is that the orange derivative that shows up when you either get all the points right or ask for that hint in derivative intuition doesn't show up in the timeline. I also noticed on at least one exercise that the guess reverts back to the default when viewing a hint that occured after a guess. |
<div class="guess"> | ||
(function(){ | ||
var guess = []; | ||
$(answers).find('.answer-label').each(function(label) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried this might not work correctly in all browsers. I've always been more comfortable with $("#answers")
rather than $(answers)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually gonna ask about this black magic. I used it in a couple other places too but wasn't sure whether it was kosher.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I've never heard of that before. I discovered that answers was a global by accident and just assumed it was Resig magic. Will revert immediately.
Seems possible there are some floating point precision bugs introduced in some of the validators. I was able to convince myself there weren't any, but there's a chance I'm wrong. You may want to monitor the bug reports a little more closely after shipping this. |
Clowncopterize! |
The derivative intuition derivative marker still doesn't show up in timeline mode but I don't think that's a bugle-stopper. Would love if you could take a look. |
Probably because raphael's This works around it if you can stand the hackyness of it:
|
I'm fine with it. There are still problems though. For some reason in timeline some (but not all) of the derivative intuition dots fail to move to the right place. Also, tutorials seem to have caused some rendering bugs but that's not a timeline problem. |
this lgtm, then |
I ported over the remaining exercises that didn't work with the timeline to the custom answer type. I also included a few little timeline improvements that have been bitrotting for a while.