Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rough attempt to run time trial for the code in the background (see #139) #154

Closed
wants to merge 1 commit into from
Closed

Rough attempt to run time trial for the code in the background (see #139) #154

wants to merge 1 commit into from

Conversation

jlfwong
Copy link
Contributor

@jlfwong jlfwong commented May 14, 2012

DO NOT MERGE

This is my work trying to catch infinite loops from blocking the UI thread whenever Web Workers are available.

There are a few blockers that prevent this from being really viable to merge at the moment.

The major problem is that this is currently only working with Output.exec because Output.runCode assumes exec is synchronous - the introduction of time trial testing with a background thread makes it async.

I'm also not totally clear how the injection process with fnCalls.push works - so if I do use runCode, then the second timeTrial won't work, because fnCalls is not defined in the worker thread.

Only using exec instead of runCode makes a lot of things not work as they should in the editor (which is why runCode was introduced in the first place, I'm guessing).

@jeresig
Copy link
Member

jeresig commented May 25, 2012

Moved over here: http://phabricator.khanacademy.org/D105

@jeresig jeresig closed this May 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants