Upgrade gulp to gulp 4 #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamelafox
commented
Sep 15, 2020
| @@ -22,8 +22,8 @@ | |||
| <script src="../../shared_utils.js"></script> | |||
| <script> | |||
| runTestFiles([ | |||
| "output_test.js", | |||
| "assert_test.js" | |||
| "assert_test.js", | |||
There was a problem hiding this comment.
I rearranged the order to match the webpage order (assert, then output) as one way to encourage mocha not to flake out on the first test.
pamelafox
commented
Sep 15, 2020
| @@ -78,7 +78,26 @@ var plugin = function (options) { | |||
| } | |||
|
|
|||
| const chrome = await launchChrome(); | |||
| const protocol = await CDP({port: chrome.port}); | |||
|
|
|||
| let protocol = null; | |||
There was a problem hiding this comment.
This is from: https://github.com/discourse/discourse/blob/master/test/run-qunit.js
Found it on this issue report:
GoogleChrome/chrome-launcher#145
Not sure why we didn't run into it before.
jeresig
approved these changes
Sep 15, 2020
|
Travis CI was happy! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High-level description of change
This PR upgrades gulp to gulp 4. There were issues with gulp 3 and the current node, so this resolves those issues.
Are there performance implications for this change?
I increased the timeout for tests to take (as the first test in the SQL output suite kept failing, despite seemingly being within the timeout), so that could increase time for tests to run. I don't think it practically does, however.
Have you added tests to cover this new/updated code?
No :)
Risks involved
There could be some flakiness with the new gulp that we haven't encountered yet. Wonder how it'll do on Travis.
Are there any dependencies or blockers for merging this?
No
How can we verify that this change works?
npm run build
npm run test