-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[interactive graph editor] Refactor sections #1416
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: +240 B (+0.03%) Total Size: 854 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1416 +/- ##
==========================================
+ Coverage 69.62% 71.17% +1.54%
==========================================
Files 504 509 +5
Lines 105597 105744 +147
Branches 7650 10841 +3191
==========================================
+ Hits 73521 75261 +1740
+ Misses 31960 30483 -1477
+ Partials 116 0 -116
... and 135 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! This editor has progressed so much over the last several sprints.
Is it possible to have the accordions for these sections be tab-able (for keyboard navigation), like what's in the Locked Figures section?
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (4065916) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1416 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1416 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for doing this!
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus-editor@8.2.0 ### Minor Changes - [#1416](#1416) [`daa3082d3`](daa3082) Thanks [@nicolecomputer](https://github.com/nicolecomputer)! - Organizes the graph editor ### Patch Changes - Updated dependencies \[[`c41662717`](c416627), [`3ff40dd23`](3ff40dd), [`a8eb6908b`](a8eb690), [`a9dbbc4b1`](a9dbbc4)]: - @khanacademy/perseus@25.1.1 ## @khanacademy/perseus@25.1.1 ### Patch Changes - [#1408](#1408) [`c41662717`](c416627) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Move code for interactive graph grids and axes to a `backgrounds` folder - [#1409](#1409) [`3ff40dd23`](3ff40dd) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph: Test Utils] Update the interactive graph question builder with all options + update testdata to use builder - [#1410](#1410) [`a8eb6908b`](a8eb690) Thanks [@benchristel](https://github.com/benchristel)! - Internal: refactor interactive graph reducer actions to make it clearer which actions go with which graph type - [#1420](#1420) [`a9dbbc4b1`](a9dbbc4) Thanks [@benchristel](https://github.com/benchristel)! - Internal: refactor interactive graph reducer actions for clarity Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), 🚫 Upload Coverage, ✅ gerald, ⏭️ Publish npm snapshot, 🚫 Cypress (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), 🚫 Jest Coverage (ubuntu-latest, 20.x), 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1419
Summary:
This puts the correct answer and locked figures into their own section so that its easier to get the right things on the screen.
Uploading editor-2.mov…
Issue: LEMS-2179
Test plan: