Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[interactive graph editor] Refactor sections #1416

Merged
merged 8 commits into from
Jul 22, 2024
Merged

Conversation

nicolecomputer
Copy link
Contributor

@nicolecomputer nicolecomputer commented Jul 15, 2024

Summary:

This puts the correct answer and locked figures into their own section so that its easier to get the right things on the screen.

Uploading editor-2.mov…

Screenshot 2024-07-16 at 1 10 43 PM

Issue: LEMS-2179

Test plan:

  • Open Storybook
  • Open a graph editor
  • You should be able to collapse and expand sections for locked figures and the correct answer

@nicolecomputer nicolecomputer self-assigned this Jul 15, 2024
@khan-actions-bot khan-actions-bot requested a review from a team July 15, 2024 19:36
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Jul 15, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/brave-turkeys-agree.md, packages/perseus-editor/src/components/heading.tsx, packages/perseus-editor/src/components/interactive-graph-correct-answer.tsx, packages/perseus-editor/src/components/interactive-graph-settings.tsx, packages/perseus-editor/src/components/start-coord-settings.tsx, packages/perseus-editor/src/widgets/interactive-graph-editor.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-figures-section.tsx, packages/perseus-editor/src/widgets/__tests__/interactive-graph-editor.test.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Jul 15, 2024

Size Change: +240 B (+0.03%)

Total Size: 854 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 273 kB +240 B (+0.09%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.2 kB
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 80.8 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 21.6 kB
packages/perseus/dist/es/index.js 414 kB
packages/perseus/dist/es/strings.js 3.21 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 97.08029% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.17%. Comparing base (8b128b5) to head (4065916).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1416      +/-   ##
==========================================
+ Coverage   69.62%   71.17%   +1.54%     
==========================================
  Files         504      509       +5     
  Lines      105597   105744     +147     
  Branches     7650    10841    +3191     
==========================================
+ Hits        73521    75261    +1740     
+ Misses      31960    30483    -1477     
+ Partials      116        0     -116     

Impacted file tree graph

Files Coverage Δ
packages/perseus-editor/src/components/heading.tsx 100.00% <100.00%> (ø)
...rc/components/interactive-graph-correct-answer.tsx 100.00% <100.00%> (ø)
...itor/src/components/interactive-graph-settings.tsx 98.81% <100.00%> (+<0.01%) ⬆️
...eus-editor/src/components/start-coord-settings.tsx 97.54% <100.00%> (+0.02%) ⬆️
...us-editor/src/widgets/interactive-graph-editor.tsx 89.03% <100.00%> (-0.26%) ⬇️
...ts/graph-locked-figures/locked-figures-section.tsx 97.80% <93.44%> (+0.15%) ⬆️

... and 135 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b128b5...4065916. Read the comment docs.

Copy link
Contributor

@mark-fitzgerald mark-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This editor has progressed so much over the last several sprints.

Is it possible to have the accordions for these sections be tab-able (for keyboard navigation), like what's in the Locked Figures section?

Copy link
Contributor

github-actions bot commented Jul 16, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (4065916) and published it to npm. You
can install it using the tag PR1416.

Example:

yarn add @khanacademy/perseus@PR1416

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1416

Copy link
Contributor

@nishasy nishasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing this!

@nicolecomputer nicolecomputer merged commit daa3082 into main Jul 22, 2024
11 checks passed
@nicolecomputer nicolecomputer deleted the new/ig-panel-reorg branch July 22, 2024 16:59
benchristel pushed a commit that referenced this pull request Jul 22, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.


# Releases
## @khanacademy/perseus-editor@8.2.0

### Minor Changes

-   [#1416](#1416) [`daa3082d3`](daa3082) Thanks [@nicolecomputer](https://github.com/nicolecomputer)! - Organizes the graph editor

### Patch Changes

-   Updated dependencies \[[`c41662717`](c416627), [`3ff40dd23`](3ff40dd), [`a8eb6908b`](a8eb690), [`a9dbbc4b1`](a9dbbc4)]:
    -   @khanacademy/perseus@25.1.1

## @khanacademy/perseus@25.1.1

### Patch Changes

-   [#1408](#1408) [`c41662717`](c416627) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Move code for interactive graph grids and axes to a `backgrounds` folder


-   [#1409](#1409) [`3ff40dd23`](3ff40dd) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph: Test Utils] Update the interactive graph question builder with all options + update testdata to use builder


-   [#1410](#1410) [`a8eb6908b`](a8eb690) Thanks [@benchristel](https://github.com/benchristel)! - Internal: refactor interactive graph reducer actions to make it clearer which actions go with which graph type


-   [#1420](#1420) [`a9dbbc4b1`](a9dbbc4) Thanks [@benchristel](https://github.com/benchristel)! - Internal: refactor interactive graph reducer actions for clarity

Author: khan-actions-bot

Reviewers: benchristel

Required Reviewers:

Approved By: benchristel

Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️  Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), 🚫 Upload Coverage, ✅ gerald, ⏭️  Publish npm snapshot, 🚫 Cypress (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), 🚫 Jest Coverage (ubuntu-latest, 20.x), 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: #1419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants