Move grid and axis code to a backgrounds folder #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (16df5ee) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1408If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1408 |
|
Size Change: -112 B (-0.01%) Total Size: 854 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1408 +/- ##
==========================================
+ Coverage 69.71% 71.05% +1.34%
==========================================
Files 505 508 +3
Lines 105131 105401 +270
Branches 7590 10761 +3171
==========================================
+ Hits 73293 74894 +1601
+ Misses 31662 30507 -1155
+ Partials 176 0 -176
... and 174 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
SonicScrewdriver
approved these changes
Jul 15, 2024
Merged
benchristel
pushed a commit
that referenced
this pull request
Jul 22, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus-editor@8.2.0 ### Minor Changes - [#1416](#1416) [`daa3082d3`](daa3082) Thanks [@nicolecomputer](https://github.com/nicolecomputer)! - Organizes the graph editor ### Patch Changes - Updated dependencies \[[`c41662717`](c416627), [`3ff40dd23`](3ff40dd), [`a8eb6908b`](a8eb690), [`a9dbbc4b1`](a9dbbc4)]: - @khanacademy/perseus@25.1.1 ## @khanacademy/perseus@25.1.1 ### Patch Changes - [#1408](#1408) [`c41662717`](c416627) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Move code for interactive graph grids and axes to a `backgrounds` folder - [#1409](#1409) [`3ff40dd23`](3ff40dd) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph: Test Utils] Update the interactive graph question builder with all options + update testdata to use builder - [#1410](#1410) [`a8eb6908b`](a8eb690) Thanks [@benchristel](https://github.com/benchristel)! - Internal: refactor interactive graph reducer actions to make it clearer which actions go with which graph type - [#1420](#1420) [`a9dbbc4b1`](a9dbbc4) Thanks [@benchristel](https://github.com/benchristel)! - Internal: refactor interactive graph reducer actions for clarity Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), 🚫 Upload Coverage, ✅ gerald, ⏭️ Publish npm snapshot, 🚫 Cypress (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), 🚫 Jest Coverage (ubuntu-latest, 20.x), 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was mostly hanging out in
interactive-graphs/, but the axis ticklabels file was in
interactive-graphs/graphs/componentsfor some reason. I'veconsolidated all this code in a
backgrounds/folder so it's easy to find.Issue: none
Test plan:
yarn test