Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export CursorContext #259

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Export CursorContext #259

merged 1 commit into from
Jun 6, 2022

Conversation

jeremywiebe
Copy link
Collaborator

Summary:

@khanacademy/math-input clients sometimes use the CursorContext as part of using the math-input project. Instead of re-defining the values in the object, this PR adds it as an export from the main module.

Issue: MOB-4525

Test plan:

@jeremywiebe jeremywiebe self-assigned this Jun 6, 2022
@jeremywiebe jeremywiebe marked this pull request as ready for review June 6, 2022 21:03
@khan-actions-bot khan-actions-bot requested a review from a team June 6, 2022 21:03
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/happy-windows-repair.md, packages/math-input/src/index.js

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

Size Change: +7 B (0%)

Total Size: 697 kB

Filename Size Change
packages/math-input/dist/es/index.js 60 kB +7 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.4 kB
packages/kmath/dist/es/index.js 4.18 kB
packages/perseus-editor/dist/es/index.js 150 kB
packages/perseus-error/dist/es/index.js 825 B
packages/perseus-linter/dist/es/index.js 19.3 kB
packages/perseus/dist/es/index.js 407 kB
packages/pure-markdown/dist/es/index.js 3.74 kB
packages/simple-markdown/dist/es/index.js 12.9 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #259 (ccb3bdd) into main (cd003e4) will increase coverage by 3.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   48.67%   52.12%   +3.45%     
==========================================
  Files         542      547       +5     
  Lines       29505    32647    +3142     
  Branches     6544     7443     +899     
==========================================
+ Hits        14361    17017    +2656     
- Misses      15144    15630     +486     
Impacted Files Coverage Δ
testing/render-question-with-cypress.jsx 95.45% <0.00%> (ø)
testing/test-dependencies.js 32.14% <0.00%> (ø)
vendor/hubble/hubble.js 36.84% <0.00%> (ø)
vendor/raphael/raphael.js 34.36% <0.00%> (ø)
testing/test-tex.jsx 88.23% <0.00%> (ø)
packages/perseus/src/util.js 56.91% <0.00%> (+0.32%) ⬆️
packages/perseus/src/util/math.js 30.06% <0.00%> (+0.69%) ⬆️
...erseus/src/interactive2/movable-polygon-options.js 58.59% <0.00%> (+0.78%) ⬆️
packages/perseus/src/util/tex.js 40.50% <0.00%> (+1.26%) ⬆️
packages/perseus/src/components/image-loader.jsx 75.00% <0.00%> (+1.56%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd003e4...ccb3bdd. Read the comment docs.

@jeremywiebe jeremywiebe merged commit 96288b8 into main Jun 6, 2022
@jeremywiebe jeremywiebe deleted the math-input-exports branch June 6, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants