Upload coverage to Coveralls when running on 'main' and feature branches #425
Conversation
🦋 Changeset detectedLatest commit: 79bacc9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: NOT Published🤕 Oh noes!! We couldn't find any changesets in this PR (e7814c7). As a result, we did not |
| coverage: | ||
| needs: [prime_cache_primary] | ||
| name: Gather coverage | ||
| name: Jest Coverage |
There was a problem hiding this comment.
These changes duplicate what's in node-ci.yml minus the needs: [prime_cache_primary].
|
Size Change: 0 B Total Size: 635 kB ℹ️ View Unchanged
|
| - name: Upload Coverage | ||
| uses: codecov/codecov-action@v3 | ||
| # We don't bother collecting a record of coverage for dependabot changes | ||
| if: ${{ github.actor != 'dependabot[bot]' }} |
There was a problem hiding this comment.
I don't think we do dependabot on this repo yet, but I'm fine leaving this here for if/when we do start using it.
Co-authored-by: Jeremy Wiebe <jeremy@khanacademy.org>
Summary:
In order for Coveralls to add comments with changes in coverage to PRs, it need to be able to run coverage on main and feature branches. This PR update node-ci-main.yml to enable this.
Issue: None
Test plan: