Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try Coveralls v1 #426

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Try Coveralls v1 #426

merged 2 commits into from
Mar 24, 2023

Conversation

kevinbarabash
Copy link
Member

Summary:

v2 is brand and may have issues so I'm going to try using v1 instead.

Issue: None

Test plan:

  • Check to see that coverage was actually reported in Coveralls

@kevinbarabash kevinbarabash self-assigned this Mar 24, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2023

🦋 Changeset detected

Latest commit: 800c053

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team March 24, 2023 00:04
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Mar 24, 2023

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/dry-berries-explode.md, .github/workflows/node-ci-main.yml, .github/workflows/node-ci.yml

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

npm Snapshot: NOT Published

🤕 Oh noes!! We couldn't find any changesets in this PR (cd7eae8). As a result, we did not
publish an npm snapshot for you.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

Size Change: 0 B

Total Size: 635 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.4 kB
packages/kmath/dist/es/index.js 4.18 kB
packages/math-input/dist/es/index.js 60.2 kB
packages/perseus-editor/dist/es/index.js 112 kB
packages/perseus-error/dist/es/index.js 825 B
packages/perseus-linter/dist/es/index.js 18.6 kB
packages/perseus/dist/es/index.js 385 kB
packages/pure-markdown/dist/es/index.js 3.74 kB
packages/simple-markdown/dist/es/index.js 12.9 kB

compressed-size-action

@kevinbarabash kevinbarabash merged commit 4ca14da into main Mar 24, 2023
@kevinbarabash kevinbarabash deleted the try-coveralls-v1 branch March 24, 2023 00:33
@coveralls
Copy link
Collaborator

coveralls commented Mar 24, 2023

Coverage Status

Coverage: 50.477% (-0.5%) from 50.995% when pulling 800c053 on try-coveralls-v1 into 2c4a774 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants