Updated TabbarItemType to KeypadPageType. #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3854db3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
Size Change: 0 B Total Size: 847 kB ℹ️ View Unchanged
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (afb3b41) and published it to npm. You Example: yarn add @khanacademy/perseus@PR676 |
handeyeco
approved these changes
Aug 21, 2023
| | "Numbers" | ||
| | "Fractions" | ||
| | "Extras" | ||
| | "Dismiss"; |
There was a problem hiding this comment.
Ugh, now "Dismiss" feels wrong; though it's not really a "Tab" either. No action needed, just pointing it out.
SonicScrewdriver
force-pushed
the
update-tab-types
branch
from
dbdf792
to
3854db3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a very simple PR that updates the name of the TabbarItemType to the more accurate/descriptive KeypadPageType.
Reason: After adding the Fractions page, not all of these elements are "TabbarItems" as we don't want the Fractions page to appear in the Tabbar. I decided on a name change as it seemed like the best course of action to ensure code readability. Otherwise the logic for showing the Fraction page would be much messier due to how we're currently switching between page views. This is also inline with our usage of the type on a few of variables/states called "selectedPage".
Issue: LC-1160
Test plan:
manual testing