Skip to content

Commit

Permalink
[versionpackages.1.actionsonpush] Use the checkout action for releases (
Browse files Browse the repository at this point in the history
#1833)

## Summary:
This uses the checkout action with ssh-key and persist-credentials to see if it fixes the release workflow so that updates to Version Packages run our expected actions.

This approach was garnered through reading various responses to changesets/action#70. Specifically:

- changesets/action#70 (comment)
- changesets/action#70 (comment)

Issue: XXX-XXXX

## Test plan:
Land this PR and see what happens with the Version Packages PR when it is created, updated, and landed.

Author: somewhatabstract

Reviewers: jandrade

Required Reviewers:

Approved By: jandrade

Checks: ✅ codecov/project, ✅ Check build sizes (ubuntu-latest, 16.x), ✅ Test (ubuntu-latest, 16.x, 2/2), ✅ Test (ubuntu-latest, 16.x, 1/2), ✅ Lint (ubuntu-latest, 16.x), ⏭  Chromatic - Build on Release PR (PR opened), ✅ gerald, ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ⏭  dependabot, ✅ Chromatic - Build on review PR (push) / chromatic (ubuntu-latest, 16.x), ⏭  Chromatic - Skip on dependabot PRs (push)

Pull Request URL: #1833
  • Loading branch information
somewhatabstract committed Mar 29, 2023
1 parent 3c40071 commit d758f20
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .changeset/brave-socks-battle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ jobs:
name: Release
runs-on: ubuntu-latest
steps:
- uses: webfactory/ssh-agent@v0.7.0
- uses: actions/checkout@v3
with:
ssh-private-key: ${{ secrets.SSH_PRIVATE_KEY }}
- name: Clone repository
run: git clone git@github.com:Khan/wonder-blocks.git .
ssh-key: ${{ secrets.SSH_PRIVATE_KEY }}
persist-credentials: false
fetch-depth: 0

- name: Install & cache node_modules
uses: Khan/actions@shared-node-cache-v0
Expand Down

0 comments on commit d758f20

Please sign in to comment.