Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VS2017 build errors in struct initialization #65

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

PanGao-h
Copy link
Contributor

@PanGao-h PanGao-h commented Sep 1, 2022

When build on VS2017, the following error triggers:

Severity Code Description Project File Line Suppression State
Error C2100 illegal indirection anari_library_example d:\opensource\anari-sdk\examples\example_device\scene\bvh\SweepSAHBuilder.h 308

The error is a bit vague and did not give the correct fail reason in fact. Since SAHTaskWorkItem is a struct and no constructor provided, a common used initialization method of struct is provided. After the fix, the project build successfully on VS2017.

When build on VS2017, the following error triggers:

> Severity	Code	Description	Project	File	Line	Suppression State
Error	C2100	illegal indirection	anari_library_example	d:\opensource\anari-sdk\examples\example_device\scene\bvh\SweepSAHBuilder.h	308	

The error is a bit vague though, but `SAHTaskWorkItem` is a struct and no constructor provided. After the fix, the project build successfully on VS2017.
@CLAassistant
Copy link

CLAassistant commented Sep 1, 2022

CLA assistant check
All committers have signed the CLA.

@jeffamstutz jeffamstutz merged commit 86dafb4 into KhronosGroup:main Sep 6, 2022
@jeffamstutz
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants