Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COLLADA2GLTF 2.0 #37

Merged
merged 334 commits into from Feb 18, 2018
Merged

COLLADA2GLTF 2.0 #37

merged 334 commits into from Feb 18, 2018

Conversation

lasalvavida
Copy link
Contributor

For #3

Current master has been checked out into the 1.0 branch. This PR would replace master with the 2.0 branch.

@emackey @pjcozzi

Rob Taglang and others added 23 commits December 29, 2017 10:21
Added support alphaMode, alphaCutoff and doubleSided attributes for M…
Node name is now written to JSON
Fixed PBR material not registering emissiveTexture
PBR Texture scale is now a float
Adds support for outputting glTF 1.0
@lasalvavida
Copy link
Contributor Author

1.0 branch is updated to the current master. This is merging now and will replace master with 2.0.

@lasalvavida lasalvavida merged commit 7077b53 into master Feb 18, 2018
@pjcozzi
Copy link
Member

pjcozzi commented Feb 18, 2018

wow, congrats @lasalvavida! The community will be really excited about this.

Do you have a list of what features and testing are still missing from the 2.0 branch, e.g., morph targets, etc? We can try to get help.

@donmccurdy
Copy link
Contributor

Great work!! 🎊

+1 for @pjcozzi's question, and:

  • Has anything changed w/r/t compiling on macOS? If not, is it possible to post a binary for macOS?
  • Are there future plans for https://cesiumjs.org/convertmodel.html ? Or an issue to track for it?

@lasalvavida
Copy link
Contributor Author

wow, congrats @lasalvavida! The community will be really excited about this.

Thanks @pjcozzi! Definitely an exciting moment that's been a while in the making.

Do you have a list of what features and testing are still missing from the 2.0 branch, e.g., morph targets, etc? We can try to get help.

Yup, morph targets still need support. As far as I know that's the only major 2.0 feature that we should support converting from COLLADA unless there is a PBR extension for COLLADA that I'm not aware of.

Has anything changed w/r/t compiling on macOS? If not, is it possible to post a binary for macOS?

I have Ahoy building for macOS in CI now, so I will be using that CI build as a template to add a Travis build for macOS here.

Are there future plans for https://cesiumjs.org/convertmodel.html ? Or an issue to track for it?

This is probably a better question for @pjcozzi since I don't work for AGI. I'm not far from emscripten builds working and that will likely be my next major focus on this project. When that happens, we'll likely host the client side conversion code as a static page somewhere.

@pjcozzi
Copy link
Member

pjcozzi commented Feb 19, 2018

Are there future plans for https://cesiumjs.org/convertmodel.html ? Or an issue to track for it?

This is probably a better question for @pjcozzi since I don't work for AGI. I'm not far from emscripten builds working and that will likely be my next major focus on this project. When that happens, we'll likely host the client side conversion code as a static page somewhere.

Wow - client-side would be amazing.

I will also ask around here about updating to 2.0. Could potentially swing it soon if it goes smoothly.

@donmccurdy do you or any of your collaborators have any bandwidth to do any additional testing of COLLADA2GLTF with glTF 2.0?

@donmccurdy
Copy link
Contributor

donmccurdy commented Feb 19, 2018

I’ll ask around internally, I’m not sure if we’re doing much with COLLADA right now... I think we would get some uptake (and free bug reports 😉)from the A-Frame community with a web-based converter. Guessing client-side would take some time to do, but discussing (donmccurdy/three-gltf-viewer#72) whether there is a straightforward way to do server side conversion in a “pluggable” setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet