Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move QNX EGL native types block (#191) #192

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Move QNX EGL native types block (#191) #192

merged 1 commit into from
Dec 1, 2023

Conversation

jmcdonnell-blackberry
Copy link
Contributor

No description provided.

stonesthrow
stonesthrow approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@stonesthrow stonesthrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@stonesthrow
Copy link
Contributor

Closes #191

oddhack
oddhack approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@oddhack oddhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though it might be helpful to run this by Mesa as they are exposed to a wide range of platforms.

@stonesthrow
Copy link
Contributor

stonesthrow commented Nov 29, 2023 •
edited
Loading

@versalinyaa , Lina do you have time for a quick review of this change to eglPlatform.h on behalf of the MESA community?

cubanismo
cubanismo approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@cubanismo cubanismo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I ran this by our embedded team as well, and they have no objections.

@stonesthrow stonesthrow added this to the Approved to Merge milestone Nov 29, 2023
@oddhack oddhack merged commit 2881aec into KhronosGroup:main Dec 1, 2023
@versalinyaa
Copy link

It's already been merged, but still lgtm.

@stonesthrow
Copy link
Contributor

We pulled the trigger and merged. thanks

@stonesthrow stonesthrow mentioned this pull request Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cubanismo cubanismo cubanismo approved these changes

@oddhack oddhack oddhack approved these changes

@stonesthrow stonesthrow stonesthrow approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Approved to Merge
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jmcdonnell-blackberry @stonesthrow @versalinyaa @cubanismo @oddhack @jmcdonnell-qnx