Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A logic error #25

Closed
linuxaged opened this issue Aug 22, 2016 · 1 comment
Closed

A logic error #25

linuxaged opened this issue Aug 22, 2016 · 1 comment

Comments

@linuxaged
Copy link

in _ktxCheckHeader function (checkheader.c):

    if (header->glTypeSize != 1 ||
        header->glTypeSize != 2 ||
        header->glTypeSize != 4)
    {
        /* Only 8, 16, and 32-bit types supported so far */
        return KTX_INVALID_VALUE;
    }

i think this will be alway true.
use '&&' instead ?

MarkCallow added a commit that referenced this issue Aug 26, 2016
MarkCallow added a commit that referenced this issue Aug 26, 2016
@MarkCallow
Copy link
Collaborator

You're right!! Thanks. Fixed in commit 3b3e794 on master and 3a47eb9 on incoming.

I'll open a new issue to remind me to create a big-endian KTX file.

MarkCallow added a commit to MarkCallow/KTX-Software that referenced this issue Jul 7, 2017
MarkCallow added a commit to MarkCallow/KTX-Software that referenced this issue Feb 29, 2020
MarkCallow added a commit to MarkCallow/KTX-Software that referenced this issue Feb 29, 2020
MarkCallow added a commit to MarkCallow/KTX-Software that referenced this issue Feb 29, 2020
KaperD pushed a commit to KaperD/KTX-Software that referenced this issue Feb 21, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this issue Feb 21, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this issue Feb 21, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this issue Feb 22, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this issue Feb 22, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this issue Feb 22, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this issue Feb 22, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this issue Feb 22, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this issue Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants