Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong block size in gl_format.h #68

Closed
suikki opened this issue Feb 8, 2019 · 5 comments
Closed

Wrong block size in gl_format.h #68

suikki opened this issue Feb 8, 2019 · 5 comments

Comments

@suikki
Copy link
Contributor

suikki commented Feb 8, 2019

On this line the blockHeight should be 5:

pFormatSize->blockHeight = 6;

Where is this code originally from?

@MarkCallow
Copy link
Collaborator

Well spotted. Thank you. The attribution is in the original copyright at the top of the file.

Can you submit a PR?

@MarkCallow
Copy link
Collaborator

Where is this code originally from?

If you mean where did I get it, I think I got it directly from Johannes van Waveren. A quick search turned up only one other copy, in the read only Vulkan-Samples repo in KhronosGroup. Anyway I have added a new function to the one in this repo so a PR is needed to fix this one.

@suikki
Copy link
Contributor Author

suikki commented Feb 11, 2019

I created a pull request: #69

If you mean where did I get it, I think I got it directly from Johannes van Waveren. A quick search turned up only one other copy, in the read only Vulkan-Samples repo in KhronosGroup. Anyway I have added a new function to the one in this repo so a PR is needed to fix this one.

I found that copy too. And yes, I was just wondering what the origin of file was so it could be fixed too.

@MarkCallow
Copy link
Collaborator

After tracking down an e-mail address I have sent a message to Johannes to let him know of the error.

@MarkCallow
Copy link
Collaborator

Fix by PR #69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants