Import KTX2Loader from threejs PR. #172
Conversation
- Imports KTX2Loader from open PR (mrdoob/three.js#18490) to consolidate development. - Adds an import map shim, to properly link KTX2Loader to the threejs CDN. - Removes requestIdleCallback invocation, so demo can be tested on Safari.
tests/webgl/llt-three/index.html
Outdated
| @@ -77,22 +81,18 @@ <h2>msc_basis_transcoder test</h2> | |||
| [THREE.RGB_ETC1_Format]: "RGB_ETC1" | |||
There was a problem hiding this comment.
Can we add THREE.RGB_ETC2_Format?
There was a problem hiding this comment.
Done – although the latest threejs release doesn't have ETC2 support yet, so (regardless of this change) the demo will likely fail on Android for now. I expect the ETC2 support will be released at the end of February.
|
From where will users of KTX2Loader.js download msc_basis_transcoder.js? (The index.html here is correctly referring to the local copy.) |
|
For now using a local copy of |
|
Damn. I should have made a branch and tested this before merging. I am getting the message in the Firefox web console. That is the only message. There is no indication of why it failed. There is nothing in the browser console either. I may have to back out this PR. |
|
Hm let me check on that, I had tested in Firefox, safari, and chrome earlier. |
|
In case it matters, I'm running the http-server included with node.js. I don't think it does because there is no sign of the browser attempting to fetch this script from my test server. |
|
Sorry. My fault. I use NoScript and had not trusted unpkg. Now I've done that, it works. |
* Import KTX2Loader from threejs PR. - Imports KTX2Loader from open PR (mrdoob/three.js#18490) to consolidate development. - Adds an import map shim, to properly link KTX2Loader to the threejs CDN. - Removes requestIdleCallback invocation, so demo can be tested on Safari. * Remove KTX2Loader. * Add comment to explain import map shim * Include ETC2 in format labels.
Imports KTX2Loader from open PR (mrdoob/three.js#18490) to consolidate development in one place. The loader now depends on changes to the threejs library (addition of ETC2 support) which means development is easier to manage over there.
The eventual goal here is that — once the KTX2Loader is released with threejs — this demo will can demonstrate KTX2 loading with the official threejs release library. If/when we later add a separate pure-JS KTX2 loader, that is engine-agnostic, we can decide how to best publish that.